This is an archive of the discontinued LLVM Phabricator instance.

Differential D149576

[bazel] Fix layering check after 0610e2f
ClosedPublic

Authored by csigg on May 1 2023, 3:05 AM.

Details

Reviewers
None
Commits
rG896af9e48da4: [bazel] Fix layering check after 0610e2f
Summary

BytecodeWriter.h is now included in IR.h, and the corresponding dependency should be moved to header_deps. This change fixes Google's internal build, which seems to have a stricter layering check than bazel's, but it's still the right thing to do.

Diff Detail

Event Timeline

csigg created this revision.May 1 2023, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 3:05 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 23 others. · View Herald Transcript
csigg requested review of this revision.May 1 2023, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 3:05 AM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B229207: Diff 518415.May 1 2023, 3:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 1 2023, 3:47 AM
Closed by commit rG896af9e48da4: [bazel] Fix layering check after 0610e2f (authored by csigg). · Explain Why
This revision was automatically updated to reflect the committed changes.
csigg added a commit: rG896af9e48da4: [bazel] Fix layering check after 0610e2f.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
2 lines

Diff 518419

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 366 Lines • ▼ Show 20 Lines hdrs = [
"include/mlir/CAPI/IntegerSet.h", "include/mlir/CAPI/IntegerSet.h",
"include/mlir/CAPI/Pass.h", "include/mlir/CAPI/Pass.h",
"include/mlir/CAPI/Registration.h", "include/mlir/CAPI/Registration.h",
"include/mlir/CAPI/Support.h", "include/mlir/CAPI/Support.h",
"include/mlir/CAPI/Utils.h", "include/mlir/CAPI/Utils.h",
"include/mlir/CAPI/Wrap.h", "include/mlir/CAPI/Wrap.h",
], ],
header_deps = [ header_deps = [
":BytecodeWriter",
":IR", ":IR",
":Pass", ":Pass",
":Support", ":Support",
"//llvm:Support", "//llvm:Support",
], ],
includes = ["include"], includes = ["include"],
deps = [ deps = [
":AsmParser", ":AsmParser",
":BytecodeWriter",
":ConversionPassIncGen", ":ConversionPassIncGen",
":FuncDialect", ":FuncDialect",
":InferTypeOpInterface", ":InferTypeOpInterface",
":Parser", ":Parser",
], ],
) )
mlir_c_api_cc_library( mlir_c_api_cc_library(
▲ Show 20 Lines • Show All 10,877 Lines • Show Last 20 Lines