This is an archive of the discontinued LLVM Phabricator instance.

Differential D149520

[InstCombine] Add tests for `(icmp pred (ssub.sat X, Y), 0)`; NFC
ClosedPublic

Authored by goldstein.w.n on Apr 29 2023, 10:39 AM.

Details

Reviewers
nikic
spatel
Commits
rG084ff0db90a6: [InstCombine] Add tests for `(icmp pred (ssub.sat X, Y), 0)`; NFC

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

goldstein.w.n created this revision.Apr 29 2023, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 10:39 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 29 2023, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 10:39 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D149521: [InstCombine] Add folds for `(icmp spred (ssub.sat X, Y), 0)` -> `X spred Y`.Apr 29 2023, 10:39 AM
Harbormaster completed remote builds in B229034: Diff 518197.Apr 29 2023, 12:34 PM
goldstein.w.n updated this revision to Diff 518329.Apr 30 2023, 8:16 AM

Rebase

Harbormaster completed remote builds in B229138: Diff 518329.Apr 30 2023, 8:50 AM
nikic accepted this revision.Apr 30 2023, 9:47 AM

LGTM

This revision is now accepted and ready to land.Apr 30 2023, 9:47 AM
goldstein.w.n mentioned this in D149577: [InstCombine] Add bswap(logic_op(bswap(x), y)) regression test case; NFC.May 1 2023, 3:34 PM
This revision was landed with ongoing or failed builds.May 3 2023, 9:12 AM
Closed by commit rG084ff0db90a6: [InstCombine] Add tests for `(icmp pred (ssub.sat X, Y), 0)`; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG084ff0db90a6: [InstCombine] Add tests for `(icmp pred (ssub.sat X, Y), 0)`; NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
101 lines

Diff 518329

llvm/test/Transforms/InstCombine/cmp-intrinsic.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s ; RUN: opt < %s -passes=instcombine -S | FileCheck %s
declare i16 @llvm.bswap.i16(i16) declare i16 @llvm.bswap.i16(i16)
declare i32 @llvm.bswap.i32(i32) declare i32 @llvm.bswap.i32(i32)
declare <2 x i64> @llvm.bswap.v2i64(<2 x i64>) declare <2 x i64> @llvm.bswap.v2i64(<2 x i64>)
declare i32 @llvm.cttz.i32(i32, i1) declare i32 @llvm.cttz.i32(i32, i1)
declare i33 @llvm.cttz.i33(i33, i1) declare i33 @llvm.cttz.i33(i33, i1)
declare i32 @llvm.ctlz.i32(i32, i1) declare i32 @llvm.ctlz.i32(i32, i1)
declare i8 @llvm.umax.i8(i8, i8) declare i8 @llvm.umax.i8(i8, i8)
declare i8 @llvm.uadd.sat.i8(i8, i8) declare i8 @llvm.uadd.sat.i8(i8, i8)
declare i8 @llvm.ssub.sat.i8(i8, i8)
declare i33 @llvm.ctlz.i33(i33, i1) declare i33 @llvm.ctlz.i33(i33, i1)
declare i8 @llvm.ctpop.i8(i8) declare i8 @llvm.ctpop.i8(i8)
declare i11 @llvm.ctpop.i11(i11) declare i11 @llvm.ctpop.i11(i11)
declare <2 x i32> @llvm.cttz.v2i32(<2 x i32>, i1) declare <2 x i32> @llvm.cttz.v2i32(<2 x i32>, i1)
declare <2 x i32> @llvm.ctlz.v2i32(<2 x i32>, i1) declare <2 x i32> @llvm.ctlz.v2i32(<2 x i32>, i1)
declare <2 x i32> @llvm.ctpop.v2i32(<2 x i32>) declare <2 x i32> @llvm.ctpop.v2i32(<2 x i32>)
declare i8 @llvm.bitreverse.i8(i8) declare i8 @llvm.bitreverse.i8(i8)
declare <2 x i8> @llvm.bitreverse.v2i8(<2 x i8>) declare <2 x i8> @llvm.bitreverse.v2i8(<2 x i8>)
▲ Show 20 Lines • Show All 855 Lines • ▼ Show 20 Lines
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[M]], 0 ; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[M]], 0
; CHECK-NEXT: ret i1 [[R]] ; CHECK-NEXT: ret i1 [[R]]
; ;
%m = call i8 @llvm.uadd.sat.i8(i8 %x, i8 %y) %m = call i8 @llvm.uadd.sat.i8(i8 %x, i8 %y)
call void @use8(i8 %m) call void @use8(i8 %m)
%r = icmp ne i8 %m, 0 %r = icmp ne i8 %m, 0
ret i1 %r ret i1 %r
} }
define i1 @ssub_sat_ne_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_ne_zero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[M]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp ne i8 %m, 0
ret i1 %r
}
define i1 @ssub_sat_ne_fail_nonzero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_ne_fail_nonzero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[M]], 4
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp ne i8 %m, 4
ret i1 %r
}
define i1 @ssub_sat_eq_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_eq_zero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[M]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp eq i8 %m, 0
ret i1 %r
}
define i1 @ssub_sat_sle_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_sle_zero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp slt i8 [[M]], 1
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp sle i8 %m, 0
ret i1 %r
}
define i1 @ssub_sat_sge_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_sge_zero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp sgt i8 [[M]], -1
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp sge i8 %m, 0
ret i1 %r
}
define i1 @ssub_sat_slt_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_slt_zero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp slt i8 [[M]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp slt i8 %m, 0
ret i1 %r
}
define i1 @ssub_sat_slt_neg1_fail(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_slt_neg1_fail(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp slt i8 [[M]], -1
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp slt i8 %m, -1
ret i1 %r
}
define i1 @ssub_sat_sgt_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_sgt_zero(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp sgt i8 [[M]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp sgt i8 %m, 0
ret i1 %r
}
define i1 @ssub_sat_sgt_one_fail(i8 %x, i8 %y) {
; CHECK-LABEL: @ssub_sat_sgt_one_fail(
; CHECK-NEXT: [[M:%.*]] = call i8 @llvm.ssub.sat.i8(i8 [[X:%.*]], i8 [[Y:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp sgt i8 [[M]], 1
; CHECK-NEXT: ret i1 [[R]]
;
%m = call i8 @llvm.ssub.sat.i8(i8 %x, i8 %y)
%r = icmp sgt i8 %m, 1
ret i1 %r
}