This is an archive of the discontinued LLVM Phabricator instance.

Differential D149519

[emacs] Highlight 'ptr' keyword as a type
ClosedPublic

Authored by goldstein.w.n on Apr 29 2023, 9:37 AM.

Details

Reviewers
melver
artagnon
nikic
Commits
rG7d3f127530c0: [emacs] Highlight 'ptr' keyword as a type
Summary

Seems natural to highlight 'ptr' same as 'void', 'i1', etc...

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 29 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 9:37 AM
goldstein.w.n requested review of this revision.Apr 29 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 9:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added reviewers: melver, artagnon.Apr 29 2023, 9:39 AM
nikic accepted this revision.Apr 29 2023, 10:05 AM
nikic added a subscriber: nikic.

LG

This revision is now accepted and ready to land.Apr 29 2023, 10:05 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 29 2023, 10:05 AM
artagnon accepted this revision.Apr 29 2023, 10:46 AM
This revision was landed with ongoing or failed builds.Apr 29 2023, 11:49 AM
Closed by commit rG7d3f127530c0: [emacs] Highlight 'ptr' keyword as a type (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG7d3f127530c0: [emacs] Highlight 'ptr' keyword as a type.
Harbormaster completed remote builds in B229027: Diff 518186.Apr 29 2023, 12:36 PM

Revision Contents

PathSize
llvm/
utils/
emacs/
2 lines

Diff 518215

llvm/utils/emacs/llvm-mode.el

Show All 30 Lines(defvar llvm-font-lock-keywords
;; Variables ;; Variables
'("%[-a-zA-Z$._][-a-zA-Z$._0-9]*" . font-lock-variable-name-face) '("%[-a-zA-Z$._][-a-zA-Z$._0-9]*" . font-lock-variable-name-face)
;; Labels ;; Labels
'("[-a-zA-Z$._0-9]+:" . font-lock-variable-name-face) '("[-a-zA-Z$._0-9]+:" . font-lock-variable-name-face)
;; Unnamed variable slots ;; Unnamed variable slots
'("%[-]?[0-9]+" . font-lock-variable-name-face) '("%[-]?[0-9]+" . font-lock-variable-name-face)
;; Types ;; Types
`(,(regexp-opt `(,(regexp-opt
'("void" "i1" "i8" "i16" "i32" "i64" "i128" "half" "bfloat" "float" "double" "fp128" "x86_fp80" "ppc_fp128" "x86_mmx" "x86_amx" '("void" "i1" "i8" "i16" "i32" "i64" "i128" "half" "bfloat" "float" "double" "fp128" "x86_fp80" "ppc_fp128" "x86_mmx" "x86_amx" "ptr"
"type" "label" "opaque" "token") 'symbols) . font-lock-type-face) "type" "label" "opaque" "token") 'symbols) . font-lock-type-face)
;; Integer literals ;; Integer literals
'("\\b[-]?[0-9]+\\b" . font-lock-preprocessor-face) '("\\b[-]?[0-9]+\\b" . font-lock-preprocessor-face)
;; Floating point constants ;; Floating point constants
'("\\b[-+]?[0-9]+.[0-9]*\\([eE][-+]?[0-9]+\\)?\\b" . font-lock-preprocessor-face) '("\\b[-+]?[0-9]+.[0-9]*\\([eE][-+]?[0-9]+\\)?\\b" . font-lock-preprocessor-face)
;; Hex constants ;; Hex constants
'("\\b0x[0-9A-Fa-f]+\\b" . font-lock-preprocessor-face) '("\\b0x[0-9A-Fa-f]+\\b" . font-lock-preprocessor-face)
;; Keywords ;; Keywords
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines