This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PSTL] Remove configurations flags
ClosedPublic

Authored by philnik on Apr 28 2023, 5:37 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG18a8bfa29707: [libc++][PSTL] Remove configurations flags
Summary

Some configurations flags are always the same. We can just remove them to make the code a bit cleaner.

Diff Detail

Event Timeline

philnik created this revision.Apr 28 2023, 5:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 5:37 PM
Herald added a subscriber: miyuki. · View Herald Transcript
philnik requested review of this revision.Apr 28 2023, 5:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 5:37 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.May 1 2023, 8:20 AM
ldionne added inline comments.
libcxx/include/__pstl/internal/pstl_config.h
35–45

If those are supported by Clang/GCC, let's keep these annotations.

57–58

Let's also check if those are supported. Basically, we should strive to retain as much semantic annotations as we can -- there's no good reason to remove them unless they are not supported by the compiler or they're wrong (but right now we must assume that everything in the original PSTL is correct unless proven otherwise).

This revision now requires changes to proceed.May 1 2023, 8:20 AM
philnik updated this revision to Diff 518492.May 1 2023, 11:05 AM
philnik marked 2 inline comments as done.

Address comments

libcxx/include/__pstl/internal/pstl_config.h
35–45

These seem to be supported. I kept the #if in the simplification patch.

57–58

This seems to be an intel extension.

philnik updated this revision to Diff 518774.May 2 2023, 9:36 AM

Try to fix CI

ldionne accepted this revision.May 2 2023, 11:36 AM
This revision is now accepted and ready to land.May 2 2023, 11:36 AM
This revision was landed with ongoing or failed builds.May 3 2023, 8:05 AM
This revision was automatically updated to reflect the committed changes.