This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Don't fold `uadd.sat` to `or` if it increase instruction count
ClosedPublic

Authored by goldstein.w.n on Apr 27 2023, 11:23 PM.

Details

Summary

In the (cmp eq/ne (uadd.sat X, Y),0) case, we where missing a
hasOneUse check.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 27 2023, 11:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:23 PM
goldstein.w.n requested review of this revision.Apr 27 2023, 11:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 11:23 PM
nikic accepted this revision.Apr 28 2023, 12:27 AM

LGTM

This revision is now accepted and ready to land.Apr 28 2023, 12:27 AM
This revision was landed with ongoing or failed builds.Apr 29 2023, 10:39 AM
This revision was automatically updated to reflect the committed changes.