This is an archive of the discontinued LLVM Phabricator instance.

[gwp_asan] Exclude recoverable tests on Fuchsia
ClosedPublic

Authored by Caslyn on Apr 26 2023, 4:56 PM.

Details

Summary

Exclude the set of tests that test recoverable code paths (i.e.
BacktraceGuardedPoolAllocator tests in recoverable.cpp) and always set
the Recoverable testing bool to false on the Fuchsia platform.
Signal handlers used by recoverable tests are unsupported on Fuchsia.

Death tests in backtrace.cpp use EXPECT_DEATH for compatibility
with zxtest.

Diff Detail

Event Timeline

Caslyn created this revision.Apr 26 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 4:56 PM
Caslyn requested review of this revision.Apr 26 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 4:56 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Caslyn edited the summary of this revision. (Show Details)Apr 26 2023, 4:59 PM
Caslyn added reviewers: hctim, fabio-d.
hctim accepted this revision.Apr 26 2023, 5:09 PM

LGTM w/ nit

compiler-rt/lib/gwp_asan/tests/harness.cpp
50–51

// Fuchsia does not support recoverable GWP-ASan.

This revision is now accepted and ready to land.Apr 26 2023, 5:09 PM
Caslyn updated this revision to Diff 517402.Apr 26 2023, 5:29 PM

Modify comment

Caslyn marked an inline comment as done.Apr 26 2023, 5:29 PM
fabio-d accepted this revision.Apr 27 2023, 10:22 AM
This revision was automatically updated to reflect the committed changes.