This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add tests for `div/rem %x, (select c, <const>, 1)`; NFC
ClosedPublic

Authored by goldstein.w.n on Apr 25 2023, 2:27 PM.

Diff Detail

Unit TestsFailed

Event Timeline

goldstein.w.n created this revision.Apr 25 2023, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 2:27 PM
goldstein.w.n requested review of this revision.Apr 25 2023, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 2:27 PM
pengfei added inline comments.Apr 25 2023, 8:21 PM
llvm/test/CodeGen/X86/divrem-by-select.ll
141

Why non_zero matters here? Dividen by 0 is posion, we don't need to cary its result.

pengfei added inline comments.Apr 25 2023, 8:27 PM
llvm/test/CodeGen/X86/divrem-by-select.ll
141

Ok, I got the point after read D149199.

pengfei accepted this revision.Apr 25 2023, 8:29 PM
This revision is now accepted and ready to land.Apr 25 2023, 8:29 PM
This revision was landed with ongoing or failed builds.Jul 12 2023, 3:18 PM
This revision was automatically updated to reflect the committed changes.