[flang] Account for .exe suffix in test/Driver/omp-driver-offload.f90.

[vzakhari]

Summary

I believe this test started failing pre-commit testing after D148038.
For example:
https://buildkite.com/llvm-project/premerge-checks/builds/148654#0187b72b-7360-4c52-be94-93eefcb269f4
https://buildkite.com/llvm-project/premerge-checks/builds/148642#0187b691-15a7-44c4-ae23-c7e97ec67755

On Windows the .exe suffix is used for clang-offload-packager tool:
"c:\\program files\\llvm\\bin\\clang-offload-packager.exe" ...

At the same time, I believe I have seen this test sporadically fail before,
meaning that the .exe suffix is not added consistently. I am not sure
why this might be happening. I decided just to allow the suffix.

[agozillon]

LGTM. I believe I re-introduced this with D148038. Thank you for catching this and the quick fix!

I'm unsure why the test would sporadically fail however, so if you encounter this again I would love to see the log so I can fix it. The same issue was introduced into the file a few weeks ago, and I believe I reintroduced it through rebasing, that is perhaps the sporadic failure, but in-case it's not just ping me on this patch if you encounter it again with the log if it's available and I'll look into it!

[vzakhari]

In D149164#4296036, @agozillon wrote:

LGTM. I believe I re-introduced this with D148038. Thank you for catching this and the quick fix!

I'm unsure why the test would sporadically fail however, so if you encounter this again I would love to see the log so I can fix it. The same issue was introduced into the file a few weeks ago, and I believe I reintroduced it through rebasing, that is perhaps the sporadic failure, but in-case it's not just ping me on this patch if you encounter it again with the log if it's available and I'll look into it!

I hope I will never see it failing again after this change :) Thank you for the review!

[agozillon]

In D149164#4296050, @vzakhari wrote:

In D149164#4296036, @agozillon wrote:

LGTM. I believe I re-introduced this with D148038. Thank you for catching this and the quick fix!

I'm unsure why the test would sporadically fail however, so if you encounter this again I would love to see the log so I can fix it. The same issue was introduced into the file a few weeks ago, and I believe I reintroduced it through rebasing, that is perhaps the sporadic failure, but in-case it's not just ping me on this patch if you encounter it again with the log if it's available and I'll look into it!

I hope I will never see it failing again after this change :) Thank you for the review!

I do too, sorry for breaking it and giving you work to do! Thank you for the fix!

[vzakhari]

I think I am missing something. I have not committed this yet, but today's pre-commit testing passes, e.g. for https://reviews.llvm.org/D149189 it passed in https://buildkite.com/llvm-project/premerge-checks/builds/148799#0187ba34-a257-4c46-b08a-65b01f9100cb
Any clues what is going on?

[vzakhari]

In D149164#4297203, @vzakhari wrote:

I think I am missing something. I have not committed this yet, but today's pre-commit testing passes, e.g. for https://reviews.llvm.org/D149189 it passed in https://buildkite.com/llvm-project/premerge-checks/builds/148799#0187ba34-a257-4c46-b08a-65b01f9100cb
Any clues what is going on?

OMG, I actually commited it, and forgot about it immediately :) I will link the revision to the review.

[agozillon]

In D149164#4297255, @vzakhari wrote:

In D149164#4297203, @vzakhari wrote:

I think I am missing something. I have not committed this yet, but today's pre-commit testing passes, e.g. for https://reviews.llvm.org/D149189 it passed in https://buildkite.com/llvm-project/premerge-checks/builds/148799#0187ba34-a257-4c46-b08a-65b01f9100cb
Any clues what is going on?

OMG, I actually commited it, and forgot about it immediately :) I will link the revision to the review.

It happens! We're all busy, some things slip our minds. Thank you for committing it ASAP though, very appreciated :-)

[awarzynski]

In D149164#4298462, @agozillon wrote:

It happens! We're all busy, some things slip our minds. Thank you for committing it ASAP though, very appreciated :-)

Totally :) And I refuse to admit what kind of random stuff I happened to commit by accident (and reverted shortly after) 😂

flang/test/Driver/omp-driver-offload.f90

 
 ! Testing appropriate flags are gnerated and appropriately assigned by the driver when offloading
 ! RUN: %flang -S -### %s -o %t 2>&1 \
 ! RUN: -fopenmp --offload-arch=gfx90a \
 ! RUN: --target=aarch64-unknown-linux-gnu \
 ! RUN:   | FileCheck %s --check-prefix=OPENMP-OFFLOAD-ARGS
 ! OPENMP-OFFLOAD-ARGS: "{{[^"]*}}flang-new" "-fc1" "-triple" "aarch64-unknown-linux-gnu" {{.*}} "-fopenmp" {{.*}}.f90"
 ! OPENMP-OFFLOAD-ARGS-NEXT: "{{[^"]*}}flang-new" "-fc1" "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fopenmp" {{.*}} "-fopenmp-host-ir-file-path" "{{.*}}.bc" "-fopenmp-is-device" {{.*}}.f90"
-! OPENMP-OFFLOAD-ARGS: "{{[^"]*}}clang-offload-packager" {{.*}} "--image=file={{.*}}.bc,triple=amdgcn-amd-amdhsa,arch=gfx90a,kind=openmp"
+! OPENMP-OFFLOAD-ARGS: "{{[^"]*}}clang-offload-packager{{.*}}" {{.*}} "--image=file={{.*}}.bc,triple=amdgcn-amd-amdhsa,arch=gfx90a,kind=openmp"
 ! OPENMP-OFFLOAD-ARGS-NEXT: "{{[^"]*}}flang-new" "-fc1" "-triple" "aarch64-unknown-linux-gnu" {{.*}} "-fopenmp" {{.*}} "-fembed-offload-object={{.*}}.out" {{.*}}.bc"
 
 ! Test -fopenmp with offload for RTL Flag Options
 ! RUN: %flang -### %s -o %t 2>&1 \
 ! RUN: -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \
 ! RUN: -fopenmp-assume-threads-oversubscription \
 ! RUN: | FileCheck %s --check-prefixes=CHECK-THREADS-OVS
 ! CHECK-THREADS-OVS: "{{[^"]*}}flang-new" "-fc1" {{.*}} "-fopenmp" {{.*}} "-fopenmp-is-device" "-fopenmp-assume-threads-oversubscription" {{.*}}.f90"