[AIX] Adjust support of format function tests

[Jake-Egan]

Summary

escaped_output.unicode.pass.cpp is failing only on 32-bit AIX. The rest are passing.

[daltenty]

Looks like we are hitting some problems with this in the pre-commit CI: https://buildkite.com/llvm-project/libcxx-ci/builds/22809#0187b445-2075-4aa1-a453-a0aa2cc8287e

[Jake-Egan]

I see - I was testing on 64-bit, but this test only fails on 32-bit AIX because _LIBCPP_SHORT_WCHAR gets defined.

[Mordante]

LGTM when the CI passes. Since I don't have access to a system with a 16-bit wchar_t it would be great if you could look at fixing the tests too.

[Jake-Egan]

• Trigger CI

[Jake-Egan]

Since I don't have access to a system with a 16-bit wchar_t it would be great if you could look at fixing the tests too.

@Mordante The test fails at the assert(false); line after calling test_ill_formed_utf16(). I haven't looked into the test in depth, so forgive me if it's obvious, but the other functions test_ill_formed_utf8() and test_ill_formed_utf32() don't assert false, so it looks like this was a mistake.

[Jake-Egan]

• Trigger CI

[Jake-Egan]

• Trigger CI

[Mordante]

I'm still happy with this patch.

In D149078#4309657, @Jake-Egan wrote:

Since I don't have access to a system with a 16-bit wchar_t it would be great if you could look at fixing the tests too.

@Mordante The test fails at the assert(false); line after calling test_ill_formed_utf16(). I haven't looked into the test in depth, so forgive me if it's obvious, but the other functions test_ill_formed_utf8() and test_ill_formed_utf32() don't assert false, so it looks like this was a mistake.

At some point I will look into this. The main issue is that the CI doesn't give nice output when things fails for wide strings. I probably write an wide to narrow string transcoder so the CI has readable output. (But this is a bit low on my priority list.)

[Jake-Egan]

• Trigger CI

libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp

 //===----------------------------------------------------------------------===//
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 
 // This version runs the test when the platform has Unicode support.
 // UNSUPPORTED: libcpp-has-no-unicode
 
-// TODO FMT Investigate Windows and AIX issues.
+// TODO FMT Investigate Windows issues.
 // UNSUPPORTED: msvc, target={{.+}}-windows-gnu
-// UNSUPPORTED: LIBCXX-AIX-FIXME
 
 // TODO FMT Fix this test using GCC, it currently crashes.
 // UNSUPPORTED: gcc-12
 
 // TODO FMT This test should not require std::to_chars(floating-point)
 // XFAIL: availability-fp_to_chars-missing
 
 // <format>

libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp

 //===----------------------------------------------------------------------===//
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 
 // This version runs the test when the platform has Unicode support.
 // UNSUPPORTED: libcpp-has-no-unicode
 
-// TODO FMT Investigate Windows and AIX issues.
+// TODO FMT Investigate Windows issues.
 // UNSUPPORTED msvc, target={{.+}}-windows-gnu
-// UNSUPPORTED: LIBCXX-AIX-FIXME
 
 // TODO FMT This test should not require std::to_chars(floating-point)
 // XFAIL: availability-fp_to_chars-missing
 
 // <format>
 
 // Tests the Unicode width support of the standard format specifiers.
 // It tests [format.string.std]/8 - 11: