Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

nicolerabjohn (Nicole Rabjohn)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2022, 8:17 AM (43 w, 3 d)

Recent Activity

Jul 6 2023

nicolerabjohn committed rG92e4d6791f71: Fixing conflicting macro definitions between curses.h and the standard library. (authored by nicolerabjohn).
Fixing conflicting macro definitions between curses.h and the standard library.
Jul 6 2023, 10:21 AM · Restricted Project, Restricted Project
nicolerabjohn closed D147356: Fixing conflicting macro definitions between curses.h and the standard library..
Jul 6 2023, 10:21 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Syncing to arcanist

Jul 6 2023, 10:16 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Fixing format for CI. Once this goes green, I'll land it.

Jul 6 2023, 6:45 AM · Restricted Project, Restricted Project

Jul 5 2023

nicolerabjohn added inline comments to D147356: Fixing conflicting macro definitions between curses.h and the standard library..
Jul 5 2023, 12:27 PM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Reordering certain code blocks, general clean-up of the patch.

Jul 5 2023, 12:26 PM · Restricted Project, Restricted Project

Jun 29 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Fix final test cases.

Jun 29 2023, 10:44 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Fixing failing test case.

Jun 29 2023, 7:34 AM · Restricted Project, Restricted Project

Jun 28 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Format fix.

Jun 28 2023, 8:43 AM · Restricted Project, Restricted Project
nicolerabjohn added a comment to D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition.

Does https://reviews.llvm.org/D143241 solve the original problem here, or is there something deeper?

Jun 28 2023, 8:40 AM · Restricted Project, Restricted Project

Jun 27 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Including __undef_macro in more header files - anywhere that move, refresh, or erase are used. This should fix the gcc compat problem.

Jun 27 2023, 12:09 PM · Restricted Project, Restricted Project

Jun 20 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Rebase

Jun 20 2023, 10:03 AM · Restricted Project, Restricted Project

Jun 14 2023

nicolerabjohn added a comment to D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition.

I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) where we hit the same assertion. There's a smaller test case, and we've done enough investigation that we understand the problem. I'd be happy to discuss over on the issue as well.

Jun 14 2023, 6:52 AM · Restricted Project, Restricted Project

May 2 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Updating testcase to use NASTY_MACROS

May 2 2023, 11:20 AM · Restricted Project, Restricted Project

Apr 27 2023

nicolerabjohn added a comment to D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Gentle ping.

Apr 27 2023, 7:01 AM · Restricted Project, Restricted Project

Apr 18 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Updating test cases to use nasty_macros.compile.pass.cpp instead of IBM-specific tests.

Apr 18 2023, 8:41 AM · Restricted Project, Restricted Project

Apr 12 2023

nicolerabjohn updated the summary of D148040: Reverting XFAILs for AIX libcpp test cases after OS update.
Apr 12 2023, 7:52 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D148040: Reverting XFAILs for AIX libcpp test cases after OS update.

Adding an additional test case that was fixed by the same update.

Apr 12 2023, 7:13 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D148040: Reverting XFAILs for AIX libcpp test cases after OS update.

Updating diff with more context.

Apr 12 2023, 6:39 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Updating diff with more context.

Apr 12 2023, 6:37 AM · Restricted Project, Restricted Project

Apr 11 2023

nicolerabjohn added a comment to D147356: Fixing conflicting macro definitions between curses.h and the standard library..

There was a fix for nasty_macros.compile.pass.cpp in a recent AIX update. I've put up https://reviews.llvm.org/D148040 to revert the XFAILs. Once that lands, I'll update this patch to put the test cases there.

Apr 11 2023, 12:41 PM · Restricted Project, Restricted Project
nicolerabjohn requested review of D148040: Reverting XFAILs for AIX libcpp test cases after OS update.
Apr 11 2023, 12:40 PM · Restricted Project, Restricted Project
nicolerabjohn added inline comments to D147356: Fixing conflicting macro definitions between curses.h and the standard library..
Apr 11 2023, 10:07 AM · Restricted Project, Restricted Project
nicolerabjohn retitled D147356: Fixing conflicting macro definitions between curses.h and the standard library. from Fixing conflicting macro definitions between curses.h and std::filesystem. to Fixing conflicting macro definitions between curses.h and the standard library..
Apr 11 2023, 8:57 AM · Restricted Project, Restricted Project
nicolerabjohn added a comment to D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Before approving I really like to know why this only affects <filesystem>. I'm slightly wary to add work-arounds for unrelated external libaries (even when curses is quite Standard).

Apr 11 2023, 8:53 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Updating formatting.

Apr 11 2023, 8:46 AM · Restricted Project, Restricted Project

Apr 6 2023

nicolerabjohn updated the summary of D147356: Fixing conflicting macro definitions between curses.h and the standard library..
Apr 6 2023, 9:58 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Updating implementation by putting macros within LIBCPP_PUSH_MACROS and LIBCPP_POP_MACROS

Apr 6 2023, 9:19 AM · Restricted Project, Restricted Project

Mar 31 2023

nicolerabjohn updated the diff for D147356: Fixing conflicting macro definitions between curses.h and the standard library..

Addressing reviewer comment to rename testcase and generalizing __undef_macros to work for all platforms.

Mar 31 2023, 4:42 PM · Restricted Project, Restricted Project
nicolerabjohn requested review of D147356: Fixing conflicting macro definitions between curses.h and the standard library..
Mar 31 2023, 1:37 PM · Restricted Project, Restricted Project

Jan 23 2023

nicolerabjohn added inline comments to D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.
Jan 23 2023, 8:28 PM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.

Update to assertions for z/OS case.

Jan 23 2023, 8:25 PM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.

Reverting previous directive change.

Jan 23 2023, 2:00 PM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.

Addressing review comments - spacing, updates to run lines, updates to a directive.

Jan 23 2023, 1:43 PM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.

Opting out of clang ABI change in FieldPacked bool on AIX.

Jan 23 2023, 12:13 PM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.

Adding run lines for AIX & z/OS, and updating comment line length.

Jan 23 2023, 10:22 AM · Restricted Project, Restricted Project
nicolerabjohn updated the diff for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.

Updating comment

Jan 23 2023, 7:45 AM · Restricted Project, Restricted Project
nicolerabjohn added a reviewer for D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS: SeanP.
Jan 23 2023, 7:40 AM · Restricted Project, Restricted Project
nicolerabjohn requested review of D142358: Opting out of Clang 16 ABI Changes for AIX and z/OS.
Jan 23 2023, 6:44 AM · Restricted Project, Restricted Project

Dec 9 2022

nicolerabjohn updated the diff for D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.

Removed extra empty line.

Dec 9 2022, 12:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 28 2022

nicolerabjohn updated the diff for D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.

Removing comment to allow for more generic use.

Nov 28 2022, 2:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
nicolerabjohn updated the diff for D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.
Nov 28 2022, 2:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
nicolerabjohn requested review of D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.
Nov 28 2022, 2:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project