This is an archive of the discontinued LLVM Phabricator instance.

[Demangle] fix another test on windows
ClosedPublic

Authored by nickdesaulniers on Apr 20 2023, 5:06 PM.

Details

Summary

Alan spotted another test failure that was a result of
https://reviews.llvm.org/D148546 when running expensive checks tests
locally on windows.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 5:06 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
nickdesaulniers requested review of this revision.Apr 20 2023, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 5:06 PM
ayzhao accepted this revision.Apr 20 2023, 5:15 PM

LGTM, confirmed this fixes the remaining broken tests on Windows:

C:\src\llvm-project\build-ninja>.\bin\llvm-lit.py ..\llvm\test\Transforms\SampleProfile\remap-2.ll
llvm-lit.py: C:\src\llvm-project\llvm\utils\lit\lit\llvm\config.py:46: note: using lit tools: C:\Program Files\Git\usr\bin
-- Testing: 1 tests, 1 workers --
PASS: LLVM :: Transforms/SampleProfile/remap-2.ll (1 of 1)

Testing Time: 0.44s
  Passed: 1

C:\src\llvm-project\build-ninja>unittests\ProfileData\ProfileDataTests.exe
[==========] Running 197 tests from 10 test suites.
[----------] Global test environment set-up.

(output redacted for brevity)

[----------] Global test environment tear-down
[==========] 197 tests from 10 test suites ran. (283 ms total)
[  PASSED  ] 197 tests.
This revision is now accepted and ready to land.Apr 20 2023, 5:15 PM
This revision was landed with ongoing or failed builds.Apr 20 2023, 5:24 PM
This revision was automatically updated to reflect the committed changes.