This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add test case for benchmarking vector copy
AbandonedPublic

Authored by hiraditya on Apr 20 2023, 3:29 PM.

Details

Reviewers
ldionne
EricWF
philnik
Group Reviewers
Restricted Project
Summary

Diff Detail

Event Timeline

hiraditya created this revision.Apr 20 2023, 3:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 3:29 PM
hiraditya requested review of this revision.Apr 20 2023, 3:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 3:29 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
hiraditya retitled this revision from Add test case for vector copy to [libc++] Add test case for benchmarking vector copy.Apr 20 2023, 5:04 PM
hiraditya updated this revision to Diff 515913.Apr 21 2023, 2:09 PM
philnik requested changes to this revision.Apr 27 2023, 1:53 PM

Let's add the benchmark and the changes in the same patch. That way you don't have to search for the benchmark/code changes.

libcxx/benchmarks/vector_operations.bench.cpp
22

This number looks weirdly specific. Why did you choose it?

This revision now requires changes to proceed.Apr 27 2023, 1:53 PM
hiraditya added inline comments.Apr 27 2023, 5:30 PM
libcxx/benchmarks/vector_operations.bench.cpp
22

copied from the test below, that's all. If you have other suggestions I'm okay with that.

Let's add the benchmark and the changes in the same patch. That way you don't have to search for the benchmark/code changes.

ok i'll abandon this patch then.