This is an archive of the discontinued LLVM Phabricator instance.

[llvm-gsymutil] Switch to OptTable
ClosedPublic

Authored by abrachet on Apr 19 2023, 7:47 PM.

Diff Detail

Event Timeline

abrachet created this revision.Apr 19 2023, 7:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 7:47 PM
abrachet requested review of this revision.Apr 19 2023, 7:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 7:47 PM
MaskRay added inline comments.Apr 21 2023, 11:14 AM
llvm/tools/llvm-gsymutil/Opts.td
22

The help message is a single letter n?

abrachet updated this revision to Diff 516866.Apr 25 2023, 1:01 PM
abrachet marked an inline comment as done.
abrachet added inline comments.
llvm/tools/llvm-gsymutil/Opts.td
22

Thanks for catching. I did this semi-programmatically, and the cl::desc got overwritten by the cl::value_desc of which it is a subclass, whoops.

MaskRay accepted this revision.Apr 25 2023, 3:05 PM
MaskRay added inline comments.
llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
98

Optional: omit = false = 0 since they are the default.

This revision is now accepted and ready to land.Apr 25 2023, 3:05 PM
This revision was landed with ongoing or failed builds.Apr 26 2023, 10:36 AM
This revision was automatically updated to reflect the committed changes.
abrachet marked an inline comment as done.
abrachet marked an inline comment as done.Apr 26 2023, 10:37 AM
abrachet added inline comments.
llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
98

Done in commit