This is an archive of the discontinued LLVM Phabricator instance.

Differential D148760

[Driver] Support response file on baremetal driver
ClosedPublic

Authored by phosek on Apr 19 2023, 4:59 PM.

Details

Reviewers
abrachet
mcgrathr
Commits
rG038536acaf27: [Driver] Support response file on baremetal driver
Summary

All officially supported linkers should support response files and
this avoids issues when compiling on platforms such as Windows.

Diff Detail

Event Timeline

phosek created this revision.Apr 19 2023, 4:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 4:59 PM
phosek requested review of this revision.Apr 19 2023, 4:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 4:59 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
abrachet accepted this revision.Apr 19 2023, 5:06 PM
This revision is now accepted and ready to land.Apr 19 2023, 5:06 PM
This revision was landed with ongoing or failed builds.Apr 19 2023, 7:52 PM
Closed by commit rG038536acaf27: [Driver] Support response file on baremetal driver (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG038536acaf27: [Driver] Support response file on baremetal driver.
phosek mentioned this in D148383: [driver] Enable response file when using lld on baremetal targets.Apr 19 2023, 8:03 PM
Harbormaster completed remote builds in B226735: Diff 515141.Apr 19 2023, 8:14 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
3 lines

Diff 515190

clang/lib/Driver/ToolChains/BareMetal.cpp

Show First 20 Lines • Show All 339 Lines • ▼ Show 20 Linesvoid baremetal::Linker::ConstructJob(Compilation &C, const JobAction &JA,
} }
if (TC.getTriple().isRISCV()) if (TC.getTriple().isRISCV())
CmdArgs.push_back("-X"); CmdArgs.push_back("-X");
CmdArgs.push_back("-o"); CmdArgs.push_back("-o");
CmdArgs.push_back(Output.getFilename()); CmdArgs.push_back(Output.getFilename());
C.addCommand(std::make_unique<Command>(JA, *this, ResponseFileSupport::None(), C.addCommand(std::make_unique<Command>(JA, *this,
ResponseFileSupport::AtFileCurCP(),
Args.MakeArgString(TC.GetLinkerPath()), Args.MakeArgString(TC.GetLinkerPath()),
CmdArgs, Inputs, Output)); CmdArgs, Inputs, Output));
} }