This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add fuchsia/io.h for TestLogger
ClosedPublic

Authored by abrachet on Apr 18 2023, 5:00 PM.

Details

Summary

b3c696fb86 started using TestLogger in tests. This class depends on
write_to_stderr which was previously only provided for Linux and
GPU's. Note, this function is used on those platforms in the libc
proper, though for Fuchsia we only ever want to provide this for
TestLogger.

No CMake files are changed because this fuchsia/ directory isn't
useful in any CMake build.

Diff Detail

Event Timeline

abrachet created this revision.Apr 18 2023, 5:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 5:00 PM
abrachet requested review of this revision.Apr 18 2023, 5:00 PM
Caslyn accepted this revision.Apr 18 2023, 5:22 PM

LGTM - the failed build doesn't look related to this change.

This revision is now accepted and ready to land.Apr 18 2023, 5:22 PM
This revision was landed with ongoing or failed builds.Apr 18 2023, 5:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 5:55 PM