This is an archive of the discontinued LLVM Phabricator instance.

Differential D148582

[lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.
ClosedPublic

Authored by jgorbe on Apr 17 2023, 4:46 PM.

Details

Reviewers
Michael137
dblaikie
aprantl
Commits
rG3c91d016349a: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.
Summary

The functionality added by https://reviews.llvm.org/D145803 is gated by
lldb tuning, so we need to build the test programs with -glldb to make
these tests print the expected preferred name.

Diff Detail

Event Timeline

jgorbe created this revision.Apr 17 2023, 4:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 4:46 PM
Herald added a subscriber: JDevlieghere. · View Herald Transcript
jgorbe requested review of this revision.Apr 17 2023, 4:46 PM
Michael137 accepted this revision.Apr 17 2023, 4:47 PM
This revision is now accepted and ready to land.Apr 17 2023, 4:47 PM
This revision was landed with ongoing or failed builds.Apr 17 2023, 5:03 PM
Closed by commit rG3c91d016349a: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb. (authored by jgorbe). · Explain Why
This revision was automatically updated to reflect the committed changes.
jgorbe added a commit: rG3c91d016349a: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb..
Harbormaster completed remote builds in B226259: Diff 514456.Apr 17 2023, 5:10 PM

Revision Contents

PathSize
lldb/
test/
API/
functionalities/
data-formatter/
data-formatter-stl/
libcxx/
shared_ptr/
4 lines
unique_ptr/
4 lines

Diff 514467

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBCPP := 1 USE_LIBCPP := 1
CXXFLAGS_EXTRAS := -std=c++14 # We need debug info tuning for lldb in order to emit the preferred name for
# std::string. See https://reviews.llvm.org/D145803.
CXXFLAGS_EXTRAS := -std=c++14 -glldb
include Makefile.rules include Makefile.rules

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBCPP := 1 USE_LIBCPP := 1
CXXFLAGS_EXTRAS := -std=c++14 # We need debug info tuning for lldb in order to emit the preferred name for
# std::string. See https://reviews.llvm.org/D145803.
CXXFLAGS_EXTRAS := -std=c++14 -glldb
include Makefile.rules include Makefile.rules