This is an archive of the discontinued LLVM Phabricator instance.

Differential D148469

Replace FLANG_BUILD_EXAMPLES with LLVM_BUILD_EXAMPLES
ClosedPublic

Authored by awarzynski on Apr 16 2023, 8:40 AM.

Details

Reviewers
DavidSpickett
gkistanova
Commits
rZORG266da4a87bf5: Replace FLANG_BUILD_EXAMPLES with LLVM_BUILD_EXAMPLES
Summary

For context, see https://reviews.llvm.org/D145992

Diff Detail

Event Timeline

awarzynski created this revision.Apr 16 2023, 8:40 AM
Herald added a reviewer: gkistanova. · View Herald TranscriptApr 16 2023, 8:40 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sunshaoce. · View Herald Transcript
awarzynski requested review of this revision.Apr 16 2023, 8:40 AM
Harbormaster completed remote builds in B225942: Diff 514020.Apr 16 2023, 8:40 AM
DavidSpickett added a comment.Apr 17 2023, 12:30 AM

You're missing an L in the commit title. "LLVM_BUID_EXAMPLES".

buildbot/osuosl/master/config/builders.py
2050

You can just remove this line.

awarzynski retitled this revision from Replace FLANG_BUILD_EXAMPLES with LLVM_BUID_EXAMPLES to Replace FLANG_BUILD_EXAMPLES with LLVM_BUILD_EXAMPLES.Apr 17 2023, 6:14 AM
awarzynski updated this revision to Diff 514196.Apr 17 2023, 6:24 AM

Remove redundant LLVM_BUILD_EXAMPLES

Harbormaster completed remote builds in B226079: Diff 514196.Apr 17 2023, 6:24 AM
DavidSpickett accepted this revision.Apr 17 2023, 6:58 AM

If you land with arc make sure the local commit title matches this one. I forget which one it chooses but its always the one I don't want it to.

LGTM.

This revision is now accepted and ready to land.Apr 17 2023, 6:58 AM
Closed by commit rZORG266da4a87bf5: Replace FLANG_BUILD_EXAMPLES with LLVM_BUILD_EXAMPLES (authored by awarzynski). · Explain WhyApr 19 2023, 1:28 PM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rZORG266da4a87bf5: Replace FLANG_BUILD_EXAMPLES with LLVM_BUILD_EXAMPLES.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
3 lines

Diff 515069

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 2,041 Lines • ▼ Show 20 Lines# Flang builders.
'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True, clean=True,
checks=['check-flang'], checks=['check-flang'],
depends_on_projects=['llvm','mlir','clang','flang'], depends_on_projects=['llvm','mlir','clang','flang'],
extra_configure_args=[ extra_configure_args=[
"-DLLVM_TARGETS_TO_BUILD=AArch64", "-DLLVM_TARGETS_TO_BUILD=AArch64",
"-DBUILD_SHARED_LIBS=ON", "-DBUILD_SHARED_LIBS=ON",
"-DLLVM_BUILD_EXAMPLES=ON", "-DLLVM_BUILD_EXAMPLES=ON",
"-DFLANG_BUILD_EXAMPLES=ON",
DavidSpickettUnsubmitted
Not Done
ReplyInline Actions

You can just remove this line.

DavidSpickett: You can just remove this line.
"-DCMAKE_CXX_STANDARD=17", "-DCMAKE_CXX_STANDARD=17",
])}, ])},
{'name' : "flang-aarch64-out-of-tree", {'name' : "flang-aarch64-out-of-tree",
'tags' : ["flang"], 'tags' : ["flang"],
'workernames' : ["linaro-flang-aarch64-out-of-tree"], 'workernames' : ["linaro-flang-aarch64-out-of-tree"],
'builddir': "flang-aarch64-out-of-tree", 'builddir': "flang-aarch64-out-of-tree",
'factory' : FlangBuilder.getFlangOutOfTreeBuildFactory( 'factory' : FlangBuilder.getFlangOutOfTreeBuildFactory(
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines# Flang builders.
'builddir': "flang-aarch64-rel-assert", 'builddir': "flang-aarch64-rel-assert",
'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True, clean=True,
checks=['check-flang'], checks=['check-flang'],
depends_on_projects=['llvm','mlir','clang','flang'], depends_on_projects=['llvm','mlir','clang','flang'],
extra_configure_args=[ extra_configure_args=[
"-DLLVM_TARGETS_TO_BUILD=AArch64", "-DLLVM_TARGETS_TO_BUILD=AArch64",
"-DLLVM_ENABLE_ASSERTIONS=ON", "-DLLVM_ENABLE_ASSERTIONS=ON",
"-DFLANG_BUILD_EXAMPLES=ON", "-DLLVM_BUILD_EXAMPLES=ON",
"-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_BUILD_TYPE=Release",
"-DCMAKE_CXX_STANDARD=17", "-DCMAKE_CXX_STANDARD=17",
])}, ])},
{'name' : "flang-aarch64-latest-gcc", {'name' : "flang-aarch64-latest-gcc",
'tags' : ['flang'], 'tags' : ['flang'],
'workernames' : ["linaro-flang-aarch64-latest-gcc"], 'workernames' : ["linaro-flang-aarch64-latest-gcc"],
'builddir': "flang-aarch64-latest-gcc", 'builddir': "flang-aarch64-latest-gcc",
▲ Show 20 Lines • Show All 648 Lines • Show Last 20 Lines