Revert "Plug-in PlatformNetBSD initializer and terminator"

[sivachandra]

Summary

This reverts commit 2354cd73101e58540b8b39783df462d06023309f as it
introduced a bunch regressions on the linux bot.

[krytarowski]

Sorry for problems, I will investigate it.

[sivachandra]

Actually, I do not have time today to do a better job with digging and have to resort to reverting.

[krytarowski]

Could you please reference a hyperlink to the breakage? Have we got some mailing list to monitor it? Jumping over logs in waterfall isn't much convenient.

[zturner]

Agreed, when a CL is reverted due to a buildbot breakage, please include a
link to the failing bot in the commit message of the revert.

[labath]

If anyone hasn't found the link yet. it's http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. There is no mailing list but you can monitor the webpage containing all builtbots. They are not sending out blame emails, as the tests are not passing 100% reliably (yet). We could add you to the opt-in list which we receive, but you'll probably regret that soon ;).

[krytarowski]

In D14844#293692, @labath wrote:

If anyone hasn't found the link yet. it's http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. There is no mailing list but you can monitor the webpage containing all builtbots. They are not sending out blame emails, as the tests are not passing 100% reliably (yet). We could add you to the opt-in list which we receive, but you'll probably regret that soon ;).

Thank you, I was looking rather for build problems.. I will need to get Linux to try it out.

At first thought I don't see relevance of NetBSD platform code to trigger asserts in the aux path.

[tberghammer]

The problem is that in PlatformNetBSD::Initialize you call
Platform::SetHostPlatform unconditionally. You want to
call Platform::SetHostPlatform only if we are running on NetBSD so you have
to surround it with some conditional compilation (see example in
PlatformLinux::Initialize)

[krytarowski]

In D14844#293787, @tberghammer wrote:

The problem is that in PlatformNetBSD::Initialize you call
Platform::SetHostPlatform unconditionally. You want to
call Platform::SetHostPlatform only if we are running on NetBSD so you have
to surround it with some conditional compilation (see example in
PlatformLinux::Initialize)

Thank you! You are right about it!

[krytarowski]

I've pasted a diff to address this regression as http://reviews.llvm.org/D14876

Please readd NetBSD platform connectors again and see what will happen.

[krytarowski]

This commit will possible break Xcode too.. but I cannot do anything with it. I will leave it to MacOSX owners.

source/Initialization/SystemInitializerCommon.cpp

#endif
 
     ObjectContainerBSDArchive::Initialize();
     ObjectFileELF::Initialize();
     ObjectFilePECOFF::Initialize();
     DynamicLoaderPOSIXDYLD::Initialize();
     DynamicLoaderWindowsDYLD::Initialize();
     platform_freebsd::PlatformFreeBSD::Initialize();
     platform_linux::PlatformLinux::Initialize();
-    platform_netbsd::PlatformNetBSD::Initialize();
     PlatformWindows::Initialize();
     PlatformKalimba::Initialize();
     platform_android::PlatformAndroid::Initialize();
 
     EmulateInstructionARM::Initialize();
     EmulateInstructionMIPS::Initialize();
     EmulateInstructionMIPS64::Initialize();
 
SystemInitializerCommon::Terminate()
     Timer scoped_timer(__PRETTY_FUNCTION__, __PRETTY_FUNCTION__);
     ObjectContainerBSDArchive::Terminate();
     ObjectFileELF::Terminate();
     ObjectFilePECOFF::Terminate();
     DynamicLoaderPOSIXDYLD::Terminate();
     DynamicLoaderWindowsDYLD::Terminate();
     platform_freebsd::PlatformFreeBSD::Terminate();
     platform_linux::PlatformLinux::Terminate();
-    platform_netbsd::PlatformNetBSD::Terminate();
     PlatformWindows::Terminate();
     PlatformKalimba::Terminate();
     platform_android::PlatformAndroid::Terminate();
     DynamicLoaderMacOSXDYLD::Terminate();
     ObjectContainerUniversalMachO::Terminate();
     PlatformMacOSX::Terminate();
     PlatformRemoteiOS::Terminate();