This is an archive of the discontinued LLVM Phabricator instance.

Differential D148411

[InstCombine] Add tests for (select (icmp x, Cp2_0), (binop y, Cp2_1), y); NFC
ClosedPublic

Authored by goldstein.w.n on Apr 14 2023, 11:11 PM.

Details

Reviewers
majnemer
spatel
nikic
craig.topper
Commits
rG4bfd7633765e: [InstCombine] Add tests for (select (icmp x, Cp2_0), (binop y, Cp2_1), y); NFC

Diff Detail

Unit TestsFailed

TimeTest
2,080 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::use-after-scope-capture.cpp
2,700 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::use-after-scope-capture.cpp

Event Timeline

goldstein.w.n created this revision.Apr 14 2023, 11:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2023, 11:11 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 14 2023, 11:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2023, 11:11 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D148412: [InstCombine] Cleanup code in foldSelectICmpAndOr; NFC.Apr 14 2023, 11:13 PM
Harbormaster completed remote builds in B225804: Diff 513846.Apr 14 2023, 11:39 PM
goldstein.w.n updated this revision to Diff 515076.Apr 19 2023, 1:43 PM

Rebase

Harbormaster completed remote builds in B226685: Diff 515076.Apr 19 2023, 2:38 PM
goldstein.w.n updated this revision to Diff 535145.Jun 27 2023, 2:45 PM

add test70_multiuse

Harbormaster completed remote builds in B241612: Diff 535145.Jun 27 2023, 4:58 PM
goldstein.w.n updated this revision to Diff 538478.Jul 9 2023, 7:09 PM

Rebase

goldstein.w.n updated this revision to Diff 538485.Jul 9 2023, 7:14 PM

Rebase

Harbormaster completed remote builds in B244027: Diff 538485.Jul 9 2023, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2023, 8:42 PM
Closed by commit rG4bfd7633765e: [InstCombine] Add tests for (select (icmp x, Cp2_0), (binop y, Cp2_1), y); NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG4bfd7633765e: [InstCombine] Add tests for (select (icmp x, Cp2_0), (binop y, Cp2_1), y); NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
31 lines

Diff 513846

llvm/test/Transforms/InstCombine/select-with-bitwise-ops.ll

Show First 20 Lines • Show All 1,566 Lines • ▼ Show 20 Lines
; CHECK-NEXT: ret i8 [[COND]] ; CHECK-NEXT: ret i8 [[COND]]
; ;
%and = and i8 %x, 250 %and = and i8 %x, 250
%or = or i8 %x, 5 %or = or i8 %x, 5
call void @use(i8 %or) call void @use(i8 %or)
%cond = select i1 %b, i8 %and, i8 %or %cond = select i1 %b, i8 %and, i8 %or
ret i8 %cond ret i8 %cond
} }
; Tests factoring in cost of saving the `and`
define i64 @xor_i8_to_i64_shl_save_and_eq(i8 %x, i64 %y) {
; CHECK-LABEL: @xor_i8_to_i64_shl_save_and_eq(
; CHECK-NEXT: [[XX:%.*]] = and i8 [[X:%.*]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i8 [[XX]], 0
; CHECK-NEXT: [[Z:%.*]] = xor i64 [[Y:%.*]], -9223372036854775808
; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP]], i64 [[Z]], i64 [[Y]]
; CHECK-NEXT: ret i64 [[R]]
;
%xx = and i8 %x, 1
%cmp = icmp eq i8 %xx, 0
%z = xor i64 %y, -9223372036854775808
%r = select i1 %cmp, i64 %z, i64 %y
ret i64 %r
}
define i64 @xor_i8_to_i64_shl_save_and_ne(i8 %x, i64 %y) {
; CHECK-LABEL: @xor_i8_to_i64_shl_save_and_ne(
; CHECK-NEXT: [[XX:%.*]] = and i8 [[X:%.*]], 1
; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp eq i8 [[XX]], 0
; CHECK-NEXT: [[Z:%.*]] = xor i64 [[Y:%.*]], -9223372036854775808
; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP_NOT]], i64 [[Y]], i64 [[Z]]
; CHECK-NEXT: ret i64 [[R]]
;
%xx = and i8 %x, 1
%cmp = icmp ne i8 %xx, 0
%z = xor i64 %y, -9223372036854775808
%r = select i1 %cmp, i64 %z, i64 %y
ret i64 %r
}