This is an archive of the discontinued LLVM Phabricator instance.

Reland D147337 "[tsan] Add debugging interfaces into interface header."
ClosedPublic

Authored by pgousseau on Apr 13 2023, 4:23 AM.

Diff Detail

Event Timeline

pgousseau created this revision.Apr 13 2023, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 4:23 AM
Herald added a subscriber: Enna1. · View Herald Transcript
pgousseau requested review of this revision.Apr 13 2023, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 4:23 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
pgousseau updated this revision to Diff 515263.Apr 20 2023, 2:54 AM

clang format test

vitalybuka accepted this revision.Apr 27 2023, 3:39 PM

Sorry didn't noticed this one.
After revert we usually reopen original, like D147337 and upload a new snapshot. This way is easier to track changes, and no need for another review for trivial updates.
LGTM, but consider to use approach above.

This revision is now accepted and ready to land.Apr 27 2023, 3:39 PM
This revision was landed with ongoing or failed builds.Apr 28 2023, 3:57 AM
This revision was automatically updated to reflect the committed changes.

Sorry didn't noticed this one.
After revert we usually reopen original, like D147337 and upload a new snapshot. This way is easier to track changes, and no need for another review for trivial updates.
LGTM, but consider to use approach above.

Makes sense yes, will do thanks!

Sorry for missing that and thank you for handling the revert, I will have a look.

pgousseau reopened this revision.May 30 2023, 2:39 AM
This revision is now accepted and ready to land.May 30 2023, 2:39 AM
pgousseau updated this revision to Diff 526567.May 30 2023, 3:27 AM

Fix mismatched type in compiler-rt/test/tsan/Darwin/debug_external.cpp:13:5: error: conflicting types for '__tsan_get_report_loc'

This revision was landed with ongoing or failed builds.May 30 2023, 3:43 AM
This revision was automatically updated to reflect the committed changes.