This change the types to match the ones used in:
Darwin/debug_external.cpp
debugging.cpp
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Sorry didn't noticed this one.
After revert we usually reopen original, like D147337 and upload a new snapshot. This way is easier to track changes, and no need for another review for trivial updates.
LGTM, but consider to use approach above.
Comment Actions
This broke the mac tests again, see e.g. the end of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8782525813244192609/+/u/package_clang/stdout
Comment Actions
Fix mismatched type in compiler-rt/test/tsan/Darwin/debug_external.cpp:13:5: error: conflicting types for '__tsan_get_report_loc'