This is an archive of the discontinued LLVM Phabricator instance.

[ReachingDefs] make ReachingDefDefaultVal smaller
ClosedPublic

Authored by yubing on Apr 13 2023, 12:13 AM.

Diff Detail

Event Timeline

yubing created this revision.Apr 13 2023, 12:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 12:13 AM
yubing requested review of this revision.Apr 13 2023, 12:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 12:13 AM
This revision is now accepted and ready to land.Apr 13 2023, 12:25 AM
This revision was landed with ongoing or failed builds.Apr 13 2023, 1:20 AM
This revision was automatically updated to reflect the committed changes.

@craig.topper hi, Craig. why we don't set it as std::numeric_limits<int>::min() previously?

@craig.topper hi, Craig. why we don't set it as std::numeric_limits<int>::min() previously?

I think it can only go as small as -(1 << 30), since the pointer traits in ReachingDef takes the last two bits.

We have seen values between -(1<<21) and -(1<<20) in some workloads tripping the Defs must be sorted and unique assertion, so it may be prudent to set it to at least -(1<<22).