This is an archive of the discontinued LLVM Phabricator instance.

Differential D148132

[compiler-rt] [test] Pass the mingw specific option for increasing stack size
ClosedPublic

Authored by mstorsjo on Apr 12 2023, 7:55 AM.

Details

Reviewers
phosek
alvinhochun
vitalybuka
Commits
rG6d7d0ed4a991: [compiler-rt] [test] Pass the mingw specific option for increasing stack size
Summary

This passes the same option that was added for MSVC builds in
fb5a24b4f03a7 in the corresponding mingw form too.

This fixes the BVGraph tests in the sanitizer unit tests.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 12 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 7:55 AM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
mstorsjo requested review of this revision.Apr 12 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 7:55 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B225071: Diff 512832.Apr 12 2023, 8:16 AM
vitalybuka accepted this revision.Apr 12 2023, 10:07 AM
This revision is now accepted and ready to land.Apr 12 2023, 10:07 AM
Closed by commit rG6d7d0ed4a991: [compiler-rt] [test] Pass the mingw specific option for increasing stack size (authored by mstorsjo). · Explain WhyApr 13 2023, 2:06 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG6d7d0ed4a991: [compiler-rt] [test] Pass the mingw specific option for increasing stack size.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
tests/
2 lines

Diff 513111

compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt

Show First 20 Lines • Show All 107 Lines • ▼ Show 20 Linesif(APPLE)
list(APPEND SANITIZER_TEST_CFLAGS_COMMON "-mmacosx-version-min=10.13") list(APPEND SANITIZER_TEST_CFLAGS_COMMON "-mmacosx-version-min=10.13")
endif() endif()
# MSVC linker is allocating 1M for the stack by default, which is not # MSVC linker is allocating 1M for the stack by default, which is not
# enough for the unittests. Some unittests require more than 2M. # enough for the unittests. Some unittests require more than 2M.
# The default stack size for clang is 8M. # The default stack size for clang is 8M.
if(MSVC) if(MSVC)
list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -Wl,/STACK:0xC00000) list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -Wl,/STACK:0xC00000)
elseif (MINGW)
list(APPEND SANITIZER_TEST_LINK_FLAGS_COMMON -Wl,--stack=0xC00000)
endif() endif()
set(SANITIZER_TEST_LINK_LIBS) set(SANITIZER_TEST_LINK_LIBS)
append_list_if(COMPILER_RT_HAS_LIBLOG log SANITIZER_TEST_LINK_LIBS) append_list_if(COMPILER_RT_HAS_LIBLOG log SANITIZER_TEST_LINK_LIBS)
# NDK r10 requires -latomic almost always. # NDK r10 requires -latomic almost always.
append_list_if(ANDROID atomic SANITIZER_TEST_LINK_LIBS) append_list_if(ANDROID atomic SANITIZER_TEST_LINK_LIBS)
append_list_if(COMPILER_RT_HAS_LIBDL -ldl SANITIZER_TEST_LINK_FLAGS_COMMON) append_list_if(COMPILER_RT_HAS_LIBDL -ldl SANITIZER_TEST_LINK_FLAGS_COMMON)
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines