This is an archive of the discontinued LLVM Phabricator instance.

Differential D148099

[lldb] Reduce chances of spurious failures in some build setups
ClosedPublic

Authored by alexfh on Apr 12 2023, 3:00 AM.

Details

Reviewers
JDevlieghere
rupprecht
brooksmoses
DavidSpickett
Commits
rGca7a20df1082: [lldb] Reduce chances of spurious failures in some build setups
Summary

The test may fail when running from a directory that contains the string used in
CHECK-NOT. We observe flakiness rate of around 3/100000. Increasing the length
helps reducing the rate of failures.

Diff Detail

Event Timeline

alexfh created this revision.Apr 12 2023, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:00 AM
alexfh requested review of this revision.Apr 12 2023, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:00 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
DavidSpickett added a subscriber: DavidSpickett.Apr 12 2023, 3:06 AM

Could you look for the full output line instead?

(lldb) expression 1+1
(int) $0 = 2

Even if $0 changes maybe = can be checked.

Harbormaster completed remote builds in B224991: Diff 512734.Apr 12 2023, 3:15 AM
alexfh updated this revision to Diff 512748.Apr 12 2023, 3:31 AM

Use full expressions in the CHECK-NOT.

Harbormaster completed remote builds in B225004: Diff 512748.Apr 12 2023, 3:32 AM
DavidSpickett accepted this revision.Apr 12 2023, 3:44 AM
DavidSpickett added a reviewer: DavidSpickett.

Looks good to me.

This revision is now accepted and ready to land.Apr 12 2023, 3:44 AM
This revision was landed with ongoing or failed builds.Apr 12 2023, 4:05 AM
Closed by commit rGca7a20df1082: [lldb] Reduce chances of spurious failures in some build setups (authored by alexfh). · Explain Why
This revision was automatically updated to reflect the committed changes.
alexfh added a commit: rGca7a20df1082: [lldb] Reduce chances of spurious failures in some build setups.
alexfh added a comment.Apr 12 2023, 4:41 AM
In D148099#4260897, @DavidSpickett wrote:

Looks good to me.

Thanks for the prompt and helpful review!

Revision Contents

PathSize
lldb/
test/
Shell/
Commands/
3 lines

Diff 512767

lldb/test/Shell/Commands/command-stop-hook-no-target.test

# RUN: %clang_host -g %S/Inputs/main.c -o %t # RUN: %clang_host -g %S/Inputs/main.c -o %t
# RUN: %lldb -b -o 'target stop-hook add --name test --shlib test -o "expression 95000 + 126"' -o 'file %t' -o 'b main' -o 'r' 2>&1 | FileCheck %s # RUN: %lldb -b -o 'target stop-hook add --name test --shlib test -o "expression 95000 + 126"' -o 'file %t' -o 'b main' -o 'r' 2>&1 | FileCheck %s
# CHECK: Stop hook #1 added # CHECK: Stop hook #1 added
# CHECK-NOT: 95126 # CHECK-NOT: (lldb) expression 95000 + 126
# CHECK-NOT: (int) $0 = 95126