This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Fix ifdefs in X86/Target.cpp

Authored by kpdev42 on Apr 10 2023, 3:04 AM.



As discussed in, the correct macro
to check together with _MSC_VER is _M_X64. Testing for _MSC_VER with
x86_64 made tests fail on Windows in

Additionally, this commit replaces a few calls to llvm_unreachable() with
report_fatal_error() because it is actually reached even on Linux/i686,
causing obscure segfaults when expanded to __builtin_unreachable().


Huawei RRI, OS Lab

Diff Detail

Event Timeline

kpdev42 created this revision.Apr 10 2023, 3:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 3:04 AM
kpdev42 requested review of this revision.Apr 10 2023, 3:04 AM
courbet accepted this revision.Apr 18 2023, 6:22 AM
This revision is now accepted and ready to land.Apr 18 2023, 6:22 AM
This revision was automatically updated to reflect the committed changes.