[compiler-rt] [test] Only pass -incremental:no to the linker for MSVC/clang-cl

[mstorsjo]

Summary

The target_is_msvc variable in lit.cfg.py matches a similar pattern
used in the asan lit.cfg.py.

[phosek]

LGTM

compiler-rt/test/profile/lit.cfg.py

26–30

Since this is only used once, you could also consider inlining it, but either way is fine.

[mstorsjo]

compiler-rt/test/profile/lit.cfg.py

26–30

Yeah - although I think I prefer keeping it separate, for similarity with the other files.

compiler-rt/test/profile/lit.cfg.py

 # -*- Python -*-
 
 import os
+import re
 
 def get_required_attr(config, attr_name):
   attr_value = getattr(config, attr_name, None)
   if attr_value == None:
     lit_config.fatal(
       "No attribute %r in test configuration! You may need to run "
       "tests from your build directory or add this attribute "
       "to lit.site.cfg.py " % attr_name)
   return attr_value
 
 # Setup config name.
 config.name = 'Profile-' + config.target_arch
 
 # Setup source root.
 config.test_source_root = os.path.dirname(__file__)
 
 # Setup executable root.
 if hasattr(config, 'profile_lit_binary_dir') and \
         config.profile_lit_binary_dir is not None:
     config.test_exec_root = os.path.join(config.profile_lit_binary_dir, config.name)
 
+target_is_msvc = bool(re.match(r'.*-windows-msvc$', config.target_triple))
+
 if config.host_os in ['Linux']:
   extra_link_flags = ["-ldl"]
-elif config.host_os in ['Windows']:
+elif target_is_msvc:
   # InstrProf is incompatible with incremental linking. Disable it as a
   # workaround.
   extra_link_flags = ["-Wl,-incremental:no"]
 else:
   extra_link_flags = []
 
 # Test suffixes.
 config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll', '.test']