[compiler-rt] [test] [builtins] Pass the right parameters for linking with -nodefaultlibs on mingw targets

[mstorsjo]

Summary

The clang-cl/MSVC case is handled above, thus consider win32 && !is_msvc
to be mingw.

This matches the list of libraries passed by e.g. the libcxx build, when
using -nodefaultlibs.

[alvinhochun]

compiler-rt/test/builtins/Unit/lit.cfg.py

51

Just wondering is this really needed? I had assumed that the lit test runner handles passing paths with backslashes just fine. Though I guess there is no harm in replacing them with forward slashes.

[mstorsjo]

compiler-rt/test/builtins/Unit/lit.cfg.py

51

See the top of the file, lines 8-17 - the user may ask to run the tests via bash instead of with lit's internal executor.

I guess the sys.platform in ['win32'] might be somehwat redundant here though - as these scripts don't really seem to be ready for cross testing anyway. (libcxx/libcxxabi/libunwind's test setup do support cross testing though.) But I'm keeping the style consistent with the other cases anyway.

I'm not sure what config.host_os refers to here - is it specifically the cross target OS, or the host running the testsuite? E.g. the asan tests use specifically the target triple, which should be unambiguous, and sys.platform also is unambiguously the host that is executing the python script.

[mstorsjo]

Ping - @alvinhochun - is your comments thread completed? If there’s no further concerns, can someone approve it?

[alvinhochun]

Sorry, I forgot about this. LGTM but I presume you already tested it and you are more familiar with it than me anyway.

compiler-rt/test/builtins/Unit/lit.cfg.py

 is_msvc = get_required_attr(config, "is_msvc")
 if is_msvc:
   base_lib = os.path.join(config.compiler_rt_libdir, "clang_rt.builtins%s.lib "
                           % config.target_suffix)
   config.substitutions.append( ("%librt ", base_lib) )
 elif config.host_os  == 'Darwin':
   base_lib = os.path.join(config.compiler_rt_libdir, "libclang_rt.osx.a ")
   config.substitutions.append( ("%librt ", base_lib + ' -lSystem ') )
+elif config.host_os  == 'Windows':
+  base_lib = os.path.join(config.compiler_rt_libdir, "libclang_rt.builtins%s.a"
+                          % config.target_suffix)
+  if sys.platform in ['win32'] and execute_external:
+    # Don't pass dosish path separator to msys bash.exe.
+    base_lib = base_lib.replace('\\', '/')
+  config.substitutions.append( ("%librt ", base_lib + ' -lmingw32 -lmoldname -lmingwex -lmsvcrt -ladvapi32 -lshell32 -luser32 -lkernel32 ') )
 else:
   base_lib = os.path.join(config.compiler_rt_libdir, "libclang_rt.builtins%s.a"
                           % config.target_suffix)
   if sys.platform in ['win32'] and execute_external:
     # Don't pass dosish path separator to msys bash.exe.
     base_lib = base_lib.replace('\\', '/')
   config.substitutions.append( ("%librt ", base_lib + ' -lc -lm ') )