The clang-cl/MSVC case is handled above, thus consider win32 && !is_msvc
to be mingw.
This matches the list of libraries passed by e.g. the libcxx build, when
using -nodefaultlibs.
Differential D147647
[compiler-rt] [test] [builtins] Pass the right parameters for linking with -nodefaultlibs on mingw targets mstorsjo on Apr 5 2023, 11:48 AM. Authored by
Details The clang-cl/MSVC case is handled above, thus consider win32 && !is_msvc This matches the list of libraries passed by e.g. the libcxx build, when
Diff Detail
Event Timeline
Comment Actions Ping - @alvinhochun - is your comments thread completed? If there’s no further concerns, can someone approve it? Comment Actions Sorry, I forgot about this. LGTM but I presume you already tested it and you are more familiar with it than me anyway. |
Just wondering is this really needed? I had assumed that the lit test runner handles passing paths with backslashes just fine. Though I guess there is no harm in replacing them with forward slashes.