[libunwind] [SEH] Allow setting/getting the register UNW_X86_64_RIP

[mstorsjo]

Summary

This fixes libunwind_01.pass.cpp for x86_64 Windows.

[cdavis5x]

Huh. I must've thought the specific number for rip would never have been passed.

[mstorsjo]

Can someone give a libunwind group approval for this one? This one is quite trivial.

[MaskRay]

Looks great!

ELF platforms use Registers_x86_64::validRegister which returns true for a reg number within [0,16].

libunwind/src/UnwindCursor.hpp

UnwindCursor<A, R>::UnwindCursor(CONTEXT *context, A &as)
   _msContext = *context;
 }
 
 
 template <typename A, typename R>
 bool UnwindCursor<A, R>::validReg(int regNum) {
   if (regNum == UNW_REG_IP || regNum == UNW_REG_SP) return true;
 #if defined(_LIBUNWIND_TARGET_X86_64)
-  if (regNum >= UNW_X86_64_RAX && regNum <= UNW_X86_64_R15) return true;
+  if (regNum >= UNW_X86_64_RAX && regNum <= UNW_X86_64_RIP) return true;
 #elif defined(_LIBUNWIND_TARGET_ARM)
   if ((regNum >= UNW_ARM_R0 && regNum <= UNW_ARM_R15) ||
       regNum == UNW_ARM_RA_AUTH_CODE)
     return true;
 #elif defined(_LIBUNWIND_TARGET_AARCH64)
   if (regNum >= UNW_AARCH64_X0 && regNum <= UNW_ARM64_X30) return true;
 #endif
   return false;
 }
 
 template <typename A, typename R>
 unw_word_t UnwindCursor<A, R>::getReg(int regNum) {
   switch (regNum) {
 #if defined(_LIBUNWIND_TARGET_X86_64)
+  case UNW_X86_64_RIP:
   case UNW_REG_IP: return _msContext.Rip;
   case UNW_X86_64_RAX: return _msContext.Rax;
   case UNW_X86_64_RDX: return _msContext.Rdx;
   case UNW_X86_64_RCX: return _msContext.Rcx;
   case UNW_X86_64_RBX: return _msContext.Rbx;
   case UNW_REG_SP:
   case UNW_X86_64_RSP: return _msContext.Rsp;
   case UNW_X86_64_RBP: return _msContext.Rbp;
#endif
   }
   _LIBUNWIND_ABORT("unsupported register");
 }
 
 template <typename A, typename R>
 void UnwindCursor<A, R>::setReg(int regNum, unw_word_t value) {
   switch (regNum) {
 #if defined(_LIBUNWIND_TARGET_X86_64)
+  case UNW_X86_64_RIP:
   case UNW_REG_IP: _msContext.Rip = value; break;
   case UNW_X86_64_RAX: _msContext.Rax = value; break;
   case UNW_X86_64_RDX: _msContext.Rdx = value; break;
   case UNW_X86_64_RCX: _msContext.Rcx = value; break;
   case UNW_X86_64_RBX: _msContext.Rbx = value; break;
   case UNW_REG_SP:
   case UNW_X86_64_RSP: _msContext.Rsp = value; break;
   case UNW_X86_64_RBP: _msContext.Rbp = value; break;