[clang][Sema][NFC] Save token name instead of the full token

[tbaeder]

Summary

This makes it a bit clearer why we're saving the token (so no need for the later comment).

I'm just not 100% sure about the lifetime of the token name.

[shafik]

clang/lib/Parse/ParseDeclCXX.cpp

962

It looks like this comes from a static array so it should be fine but let's see what Aaron says.

[aaron.ballman]

LGTM! There shouldn't be any lifetime issues from this, as @shafik pointed out, the pointer originates in a static array defined in TokenKinds.cpp.

clang/lib/Parse/ParseDeclCXX.cpp

 ///
 /// [C11]   static_assert-declaration:
 ///           _Static_assert ( constant-expression  ,  string-literal  ) ;
 ///
 Decl *Parser::ParseStaticAssertDeclaration(SourceLocation &DeclEnd) {
   assert(Tok.isOneOf(tok::kw_static_assert, tok::kw__Static_assert) &&
          "Not a static_assert declaration");
 
-  // Save the token used for static assertion.
-  Token SavedTok = Tok;
+  // Save the token name used for static assertion.
+  const char *TokName = Tok.getName();
 
   if (Tok.is(tok::kw__Static_assert) && !getLangOpts().C11)
     Diag(Tok, diag::ext_c11_feature) << Tok.getName();
   if (Tok.is(tok::kw_static_assert)) {
     if (!getLangOpts().CPlusPlus) {
       if (getLangOpts().C2x)
         Diag(Tok, diag::warn_c2x_compat_keyword) << Tok.getName();
       else
if (AssertMessage.isInvalid()) {
       SkipMalformedDecl();
       return nullptr;
     }
   }
 
   T.consumeClose();
 
   DeclEnd = Tok.getLocation();
-  // Passing the token used to the error message.
-  ExpectAndConsumeSemi(diag::err_expected_semi_after_static_assert,
-                       SavedTok.getName());
+  ExpectAndConsumeSemi(diag::err_expected_semi_after_static_assert, TokName);
 
   return Actions.ActOnStaticAssertDeclaration(StaticAssertLoc, AssertExpr.get(),
                                               AssertMessage.get(),
                                               T.getCloseLocation());
 }
 
 /// ParseDecltypeSpecifier - Parse a C++11 decltype specifier.
 ///