This is an archive of the discontinued LLVM Phabricator instance.

Differential D14751

[asan] Enable halt_on_error tests on ARM targets
ClosedPublic

Authored by ygribov on Nov 17 2015, 9:43 AM.

Details

Reviewers
rengolin
samsonov
Commits
rGdd679b334b1c: [asan] Enable halt_on_error tests on ARM targets.
rCRT253549: [asan] Enable halt_on_error tests on ARM targets.
rL253549: [asan] Enable halt_on_error tests on ARM targets.
Summary

This patch enables recent halt_on_error feature on ARM targets. We've tested it locally on Juno and it seems to work robustly (which is expected as the feature is rather primitive).

Diff Detail

Repository
rL LLVM

Event Timeline

ygribov updated this revision to Diff 40404.Nov 17 2015, 9:43 AM
ygribov retitled this revision from to [asan] Enable halt_on_error tests on ARM targets.
ygribov updated this object.
ygribov added a reviewer: rengolin.
ygribov set the repository for this revision to rL LLVM.
ygribov added a subscriber: llvm-commits.
Herald added subscribers: rengolin, aemerson. · View Herald TranscriptNov 17 2015, 9:43 AM
rengolin edited edge metadata.Nov 17 2015, 10:48 AM

Thanks Yuri! I'll run them here and will let you know ASAP.

samsonov accepted this revision.Nov 17 2015, 4:00 PM
samsonov added a reviewer: samsonov.
samsonov added a subscriber: samsonov.

LGTM

This revision is now accepted and ready to land.Nov 17 2015, 4:00 PM
rengolin accepted this revision.Nov 18 2015, 3:23 AM
rengolin edited edge metadata.

Both 39 and 42 VMA green, good to go, thanks!

Closed by commit rL253549: [asan] Enable halt_on_error tests on ARM targets. (authored by ygribov). · Explain WhyNov 19 2015, 12:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
Posix/
2 lines
2 lines

Diff 40609

compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-signals.c

// Test interaction of Asan recovery mode with asynch signals. // Test interaction of Asan recovery mode with asynch signals.
// //
// RUN: %clang_asan -fsanitize-recover=address -pthread %s -o %t // RUN: %clang_asan -fsanitize-recover=address -pthread %s -o %t
// //
// RUN: rm -f %t.log // RUN: rm -f %t.log
// RUN: %env_asan_opts=halt_on_error=false %run %t 100 >%t.log 2>&1 || true // RUN: %env_asan_opts=halt_on_error=false %run %t 100 >%t.log 2>&1 || true
// Collision will almost always get triggered but we still need to check the unlikely case: // Collision will almost always get triggered but we still need to check the unlikely case:
// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < %t.log || FileCheck --check-prefix=CHECK-NO-COLLISION %s < %t.log // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < %t.log || FileCheck --check-prefix=CHECK-NO-COLLISION %s < %t.log
//
// REQUIRES: stable-runtime
#define _SVID_SOURCE 1 // SA_NODEFER #define _SVID_SOURCE 1 // SA_NODEFER
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <pthread.h> #include <pthread.h>
#include <time.h> #include <time.h>
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines

compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc

// Stress test recovery mode with many threads. // Stress test recovery mode with many threads.
// //
// RUN: %clangxx_asan -fsanitize-recover=address -pthread %s -o %t // RUN: %clangxx_asan -fsanitize-recover=address -pthread %s -o %t
// //
// RUN: %env_asan_opts=halt_on_error=false %run %t 1 10 >1.txt 2>&1 // RUN: %env_asan_opts=halt_on_error=false %run %t 1 10 >1.txt 2>&1
// RUN: FileCheck %s < 1.txt // RUN: FileCheck %s < 1.txt
// RUN: [ $(grep -c 'ERROR: AddressSanitizer: use-after-poison' 1.txt) -eq 10 ] // RUN: [ $(grep -c 'ERROR: AddressSanitizer: use-after-poison' 1.txt) -eq 10 ]
// RUN: FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt // RUN: FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
// //
// Collisions are unlikely but still possible so we need the ||. // Collisions are unlikely but still possible so we need the ||.
// RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt 2>&1 || true // RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt 2>&1 || true
// This one is racy although _very_ unlikely to fail: // This one is racy although _very_ unlikely to fail:
// RUN: FileCheck %s < 10.txt // RUN: FileCheck %s < 10.txt
// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt
//
// REQUIRES: stable-runtime
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <pthread.h> #include <pthread.h>
#include <time.h> #include <time.h>
#include <sanitizer/asan_interface.h> #include <sanitizer/asan_interface.h>
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines