This is here for local unwinding, which unw_resume() restores
the machine state and then directly resumes execution in the
target stack frame.
Details
Details
- Reviewers
SixWeining wangleiat xen0n MaskRay arichardson - Group Reviewers
Restricted Project - Commits
- rG366c5474a300: [libunwind][test] Add test to check for unw_resume()
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
(1) Test pass on X86
$ ninja check-unwind Testing Time: 0.29s Unsupported: 2 Passed : 12
(2) Test results on LoongArch
$ ninja check-unwind Testing Time: 0.57s Unsupported : 6 Passed : 7 Expectedly Failed: 1
Comment Actions
There are many CI failures including AIX, FreeBSD and MSAN.
Seems we should add REQUIRES and XFAIL like other tests:
$ grep -rn REQUIRE libunwind/test/ libunwind/test/unwind_leaffunction.pass.cpp:11:// REQUIRES: linux && (target={{aarch64-.+}} || target={{s390x-.+}} || target={{x86_64-.+}}) libunwind/test/floatregister.pass.cpp:10:// REQUIRES: linux && target={{aarch64-.+}} libunwind/test/remember_state_leak.pass.sh.s:9:# REQUIRES: target={{x86_64-.+-linux-gnu}} libunwind/test/bad_unwind_info.pass.cpp:13:// REQUIRES: linux && (target={{aarch64-.+}} || target={{s390x-.+}} || target={{x86_64-.+}}) libunwind/test/forceunwind.pass.cpp:10:// REQUIRES: linux libunwind/test/signal_unwind.pass.cpp:11:// REQUIRES: linux && (target={{aarch64-.+}} || target={{s390x-.+}} || target={{x86_64-.+}}) libunwind/test/unwind_scalable_vectors.pass.cpp:10:// REQUIRES: linux && target={{riscv64-.+}}
$ grep -rn msan libunwind/test/ libunwind/test/unwind_leaffunction.pass.cpp:14:// XFAIL: msan libunwind/test/signal_frame.pass.cpp:16:// XFAIL: msan libunwind/test/libunwind_01.pass.cpp:14:// XFAIL: msan libunwind/test/libunwind_02.pass.cpp:11:// XFAIL: msan libunwind/test/remember_state_leak.pass.sh.s:12:# UNSUPPORTED: msan libunwind/test/bad_unwind_info.pass.cpp:19:// UNSUPPORTED: msan libunwind/test/forceunwind.pass.cpp:13:// XFAIL: msan libunwind/test/signal_unwind.pass.cpp:14:// XFAIL: msan
libunwind/test/unw_resume.pass.cpp | ||
---|---|---|
14 | This is overly restrictive, the test looks like it should work anywhere so there should instead be xfails for the cases that are failing. I know this is what other tests are doing but those should also be changed IMO. |
libunwind/test/unw_resume.pass.cpp | ||
---|---|---|
14 | Updated it. |
This is overly restrictive, the test looks like it should work anywhere so there should instead be xfails for the cases that are failing.
I know this is what other tests are doing but those should also be changed IMO.