Details
- Reviewers
jeffbailey - Commits
- rG733ac920be3f: [libc] Add two more recipes to do a cross build.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comments within. Generally LGTM
libc/docs/full_cross_build.rst | ||
---|---|---|
39 | I'd say "a system or custom compiler is used ..." | |
67–68 | I'd like us to move from <...> notation to $VAR notation. That way someone could set the variables and cut&paste. | |
102 | Are there protections against version mismatch? I'm a little reluctant to document this process if an out of date tool might cause silent corruption. | |
139 | The notation <...> has been used here for things that should be replaced, so whether it's $... or <...> this should be used here. | |
220 | typo |
Address comments and elaborate few items.
libc/docs/full_cross_build.rst | ||
---|---|---|
102 | I have added some text to explain that libc-hdrgen and the libc should be in sync. |
I'd say "a system or custom compiler is used ..."