This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add two more recipes to do a cross build.
ClosedPublic

Authored by sivachandra on Mar 31 2023, 12:21 PM.

Diff Detail

Event Timeline

sivachandra created this revision.Mar 31 2023, 12:21 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 31 2023, 12:21 PM
sivachandra requested review of this revision.Mar 31 2023, 12:21 PM
jeffbailey accepted this revision.Mar 31 2023, 12:43 PM

Comments within. Generally LGTM

libc/docs/full_cross_build.rst
39

I'd say "a system or custom compiler is used ..."

58

I'd like us to move from <...> notation to $VAR notation. That way someone could set the variables and cut&paste.

93

Are there protections against version mismatch? I'm a little reluctant to document this process if an out of date tool might cause silent corruption.

130

The notation <...> has been used here for things that should be replaced, so whether it's $... or <...> this should be used here.

201

typo

This revision is now accepted and ready to land.Mar 31 2023, 12:43 PM
sivachandra marked 3 inline comments as done.

Address comments and elaborate few items.

libc/docs/full_cross_build.rst
93

I have added some text to explain that libc-hdrgen and the libc should be in sync.

Actually fix a typo.

jeffbailey added inline comments.Apr 1 2023, 9:52 PM
libc/docs/full_cross_build.rst
94

I'd say "MUST" here. RFC 2119/8174 =)

190

I'd do this one too.

sivachandra marked 2 inline comments as done.

Rebase and address comments.

This revision was landed with ongoing or failed builds.Apr 18 2023, 12:40 PM
This revision was automatically updated to reflect the committed changes.