Details
Diff Detail
Event Timeline
compiler-rt/include/sanitizer/tsan_interface.h | ||
---|---|---|
21 | Yes makes sense, fixed now thanks! |
@dvyukov This LGTM, do you have any concerns exposing this API?
They are already used by Apple debugger, so in some sense they are already exposed and the info we provide with reports did not change in the past 10 years, so I think it's OK.
If we won't have some of that data in future, we can just start returning errors, or null pointers from these functions.
Thank you for the review!
compiler-rt/include/sanitizer/tsan_interface.h | ||
---|---|---|
187 | Yes we would be interested in adding doxygen style comments to the whole tsan header at least so future api's comments will also hopefully be using doxygen. Will put in my TODOs, thanks! |
This broke the tsan tests on Darwin, see e.g. the end of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8784015461553130001/+/u/package_clang/stdout
It seems those tests have their own declarations of some of these functions, which mismatch slightly.
It's still broken after the follow-up, e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8783975392120859201/+/u/package_clang/stdout
I'll revert this for now.
Sorry about that, thank you for reverting. I will update the patch with hopefully better types.
we don't have tsan for windows