Page MenuHomePhabricator
Differential D147275

[InstCombine] Extend simplifications for `(icmp ({z|s}ext X), C)` where `C` is vector
ClosedPublic
Actions

Authored by goldstein.w.n on Mar 30 2023, 2:29 PM.

Details

Reviewers
nikic
spatel
majnemer
Commits
rG87c97d052cfd: [InstSimplify] Extend simplifications for `(icmp ({z|s}ext X), C)` where `C` is…
Summary

Previous logic only applied for ConstantInt which misses all vector
cases. New code works for splat/non-splat vectors as well. No change
to the underlying simplifications.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Mar 30 2023, 2:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 2:29 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Mar 30 2023, 2:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 2:29 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added reviewers: nikic, spatel, majnemer.Mar 30 2023, 2:30 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptMar 30 2023, 2:30 PM
goldstein.w.n added a child revision: D147274: [InstCombine] Add tests for simplifying `(icmp ({z|s}ext X), C)` where `C` is vector; NFC.Mar 30 2023, 2:30 PM
Harbormaster completed remote builds in B222852: Diff 509821.Mar 30 2023, 2:30 PM
nikic accepted this revision.Apr 2 2023, 1:36 AM

LGTM

llvm/lib/Analysis/InstructionSimplify.cpp
3822–3823
This revision is now accepted and ready to land.Apr 2 2023, 1:36 AM
This revision was landed with ongoing or failed builds.Apr 3 2023, 9:05 AM
Closed by commit rG87c97d052cfd: [InstSimplify] Extend simplifications for `(icmp ({z|s}ext X), C)` where `C` is… (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG87c97d052cfd: [InstSimplify] Extend simplifications for `(icmp ({z|s}ext X), C)` where `C` is….

Revision Contents
Changeset List

PathSize
llvm/
lib/
Analysis/
58 lines
test/
Transforms/
InstSimplify/
48 lines

Diff 510526

View Options

llvm/lib/Analysis/InstructionSimplify.cpp

Loading...
View Options

llvm/test/Transforms/InstSimplify/vec-icmp-of-cast.ll

Loading...