This is an archive of the discontinued LLVM Phabricator instance.

[mlir][scf] Create constants for tiling in a parent with isolated region.
ClosedPublic

Authored by olegshyshkov on Mar 30 2023, 2:18 PM.

Details

Summary

FuncOp is IsolatedFromAbove, so this change doesn't alter current behaviour, but the current code fails if the tile op is in an op with IsolatedFromAbove trait.

An alternative would be to create constant in the same region where they're used a rely on CSE to figure out where to move them.

Diff Detail

Event Timeline

olegshyshkov created this revision.Mar 30 2023, 2:18 PM
olegshyshkov requested review of this revision.Mar 30 2023, 2:18 PM
pifon2a accepted this revision.Mar 31 2023, 9:20 AM
This revision is now accepted and ready to land.Mar 31 2023, 9:20 AM