This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch][NFC] Add tests of additions with immediates (for D147222)
ClosedPublic

Authored by benshi001 on Mar 30 2023, 5:06 AM.

Diff Detail

Event Timeline

benshi001 created this revision.Mar 30 2023, 5:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 5:06 AM
benshi001 requested review of this revision.Mar 30 2023, 5:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 5:06 AM
xen0n accepted this revision.Mar 30 2023, 5:21 AM

Nit: this is preparatory change adding baseline test cases for D147222, so the title may be tweaked a little bit, or you may add some commit message, to not suggest such tests were totally absent otherwise.

Otherwise LGTM, thanks.

This revision is now accepted and ready to land.Mar 30 2023, 5:21 AM
benshi001 retitled this revision from [LoongArch][NFC] Add tests of additions with immediates to [LoongArch][NFC] Add tests of additions with immediates (for D147222).Mar 30 2023, 5:25 AM

Nit: this is preparatory change adding baseline test cases for D147222, so the title may be tweaked a little bit, or you may add some commit message, to not suggest such tests were totally absent otherwise.

Otherwise LGTM, thanks.

Thanks. I have retitled.

SixWeining added inline comments.Mar 30 2023, 7:30 AM
llvm/test/CodeGen/LoongArch/ir-instruction/add.ll
719

Besides +-4080, it’s better to add tests for the boundary, i.e. [-4096,-2049] or [2048,4094].

benshi001 updated this revision to Diff 509871.Mar 30 2023, 6:21 PM
benshi001 marked an inline comment as done.
benshi001 added inline comments.
llvm/test/CodeGen/LoongArch/ir-instruction/add.ll
719

All the boundary values are added. Thanks.

benshi001 marked an inline comment as done.Mar 30 2023, 6:23 PM
XiaodongLoong accepted this revision.Mar 30 2023, 11:31 PM

LGTM. Thanks.

SixWeining accepted this revision.Mar 30 2023, 11:42 PM