This is an archive of the discontinued LLVM Phabricator instance.

Differential D147207

[llvm-mc] Fix line_end_with_space.test
ClosedPublic

Authored by aidengrossman on Mar 30 2023, 1:36 AM.

Details

Reviewers
mehdi_amini
MaskRay
Commits
rG71dbd864f19f: [llvm-mc] Fix line_end_with_space.test
Summary

Currently, this test doesn't test what it was originally intended to
(that lvm-mc doesn't crash when disassembling a line that ends with a
space). This patch readds the space to the input so that this
functionality is actually tested and adds a comment describing what the
test does. The space seems to have been inadvertently removed in
c8d578311473fceb50579906658b0c017ef5b193 and then never added back
in.

Diff Detail

Event Timeline

aidengrossman created this revision.Mar 30 2023, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 1:36 AM
aidengrossman requested review of this revision.Mar 30 2023, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 1:36 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aidengrossman added reviewers: mehdi_amini, MaskRay.Mar 30 2023, 1:43 AM
Harbormaster completed remote builds in B222672: Diff 509573.Mar 30 2023, 2:05 AM
MaskRay accepted this revision.Mar 30 2023, 7:12 PM

Your change to line_end_with_space.test does not seem to end with a non-newline whitespace.

Something like RUN: echo -n ' ' | llvm-mc -disassemble may be more obvious.

This revision is now accepted and ready to land.Mar 30 2023, 7:12 PM
Closed by commit rG71dbd864f19f: [llvm-mc] Fix line_end_with_space.test (authored by aidengrossman). · Explain WhyMar 31 2023, 4:27 PM
This revision was automatically updated to reflect the committed changes.
aidengrossman added a commit: rG71dbd864f19f: [llvm-mc] Fix line_end_with_space.test.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-mc/
4 lines

Diff 510145

llvm/test/tools/llvm-mc/line_end_with_space.test

RUN: llvm-mc -disassemble %s # Test that llvm-mc doesn't crash when disassembling a line that ends with a
# space.
RUN: echo -n ' ' | llvm-mc -disassemble