This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add LIBC_INLINE macro to RPC implementation
ClosedPublic

Authored by jhuber6 on Mar 29 2023, 1:25 PM.

Details

Summary

These were required by the llvmlibc linter.

Diff Detail

Event Timeline

jhuber6 created this revision.Mar 29 2023, 1:25 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 29 2023, 1:25 PM
jhuber6 requested review of this revision.Mar 29 2023, 1:25 PM
lntue added inline comments.Mar 29 2023, 2:53 PM
libc/src/__support/RPC/rpc.h
77–82

@sivachandra: Do these templates need to be annotated too?

sivachandra accepted this revision.Mar 29 2023, 3:02 PM
sivachandra added inline comments.
libc/src/__support/RPC/rpc.h
77–82

Yes, this should be:

template <typename W, typename C>
LIBC_INLINE bool handle(W, C);
This revision is now accepted and ready to land.Mar 29 2023, 3:02 PM
jhuber6 updated this revision to Diff 509484.Mar 29 2023, 3:04 PM

Adding more LIBC_INLINE

This revision was automatically updated to reflect the committed changes.