This is an archive of the discontinued LLVM Phabricator instance.

Differential D147077

[compiler-rt] Avoid double-prefixing aliases with __USER_LABEL_PREFIX__
ClosedPublic

Authored by barannikov88 on Mar 28 2023, 1:28 PM.

Details

Reviewers
dim
fdischner
phosek
Commits
rG5e09b172d9ea: [compiler-rt] Avoid double-prefixing aliases with __USER_LABEL_PREFIX__
Summary

The prefix is added by DECLARE_SYMBOL_VISIBILITY. Calling SYMBOL_NAME
resulted in adding the prefix twice.

Diff Detail

Event Timeline

barannikov88 created this revision.Mar 28 2023, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 1:28 PM
Herald added subscribers: Enna1, jeroen.dobbelaere, dberris. · View Herald Transcript
barannikov88 requested review of this revision.Mar 28 2023, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 1:28 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
barannikov88 added reviewers: dim, fdischner, phosek.Mar 28 2023, 1:32 PM
Harbormaster completed remote builds in B222329: Diff 509114.Mar 28 2023, 1:50 PM
barannikov88 mentioned this in D147085: [crt] Stringize __USER_LABEL_PREFIX__ in asm strings.Mar 28 2023, 3:34 PM
barannikov88 added a comment.Apr 1 2023, 5:51 AM

ping

dim accepted this revision.Apr 2 2023, 8:11 AM

LGTM, good catch!

This revision is now accepted and ready to land.Apr 2 2023, 8:11 AM
This revision was landed with ongoing or failed builds.Apr 2 2023, 8:34 AM
Closed by commit rG5e09b172d9ea: [compiler-rt] Avoid double-prefixing aliases with __USER_LABEL_PREFIX__ (authored by barannikov88). · Explain Why
This revision was automatically updated to reflect the committed changes.
barannikov88 added a commit: rG5e09b172d9ea: [compiler-rt] Avoid double-prefixing aliases with __USER_LABEL_PREFIX__.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
2 lines

Diff 510354

compiler-rt/lib/builtins/assembly.h

Show First 20 Lines • Show All 261 Lines • ▼ Show 20 Lines#define DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(name) \
DECLARE_SYMBOL_VISIBILITY_UNMANGLED(name) SEPARATOR \ DECLARE_SYMBOL_VISIBILITY_UNMANGLED(name) SEPARATOR \
CFI_START SEPARATOR \ CFI_START SEPARATOR \
DECLARE_FUNC_ENCODING \ DECLARE_FUNC_ENCODING \
name: SEPARATOR BTI_C name: SEPARATOR BTI_C
#define DEFINE_COMPILERRT_FUNCTION_ALIAS(name, target) \ #define DEFINE_COMPILERRT_FUNCTION_ALIAS(name, target) \
.globl SYMBOL_NAME(name) SEPARATOR \ .globl SYMBOL_NAME(name) SEPARATOR \
SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR \ SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR \
DECLARE_SYMBOL_VISIBILITY(SYMBOL_NAME(name)) SEPARATOR \ DECLARE_SYMBOL_VISIBILITY(name) SEPARATOR \
.set SYMBOL_NAME(name), SYMBOL_NAME(target) SEPARATOR .set SYMBOL_NAME(name), SYMBOL_NAME(target) SEPARATOR
#if defined(__ARM_EABI__) #if defined(__ARM_EABI__)
#define DEFINE_AEABI_FUNCTION_ALIAS(aeabi_name, name) \ #define DEFINE_AEABI_FUNCTION_ALIAS(aeabi_name, name) \
DEFINE_COMPILERRT_FUNCTION_ALIAS(aeabi_name, name) DEFINE_COMPILERRT_FUNCTION_ALIAS(aeabi_name, name)
#else #else
#define DEFINE_AEABI_FUNCTION_ALIAS(aeabi_name, name) #define DEFINE_AEABI_FUNCTION_ALIAS(aeabi_name, name)
#endif #endif
Show All 14 Lines