This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] if lit can't find llvm-exegesis, fail gracefully
ClosedPublic

Authored by stuij on Mar 27 2023, 7:36 AM.

Details

Summary

currently in can_use_perfcounters() in
llvm/test/tools/llvm-exegesis/lit.local.cfg, we check if we can execute
llvm-exegesis. But we don't check if we did actually find llvm-exegesis. If we
didn't, lit.util.which() will return None, and we try to execute that.

Diff Detail

Event Timeline

stuij created this revision.Mar 27 2023, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 7:36 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
stuij requested review of this revision.Mar 27 2023, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 7:36 AM
stuij updated this revision to Diff 508654.Mar 27 2023, 7:42 AM

amend commit message

courbet accepted this revision.Mar 27 2023, 7:48 AM
This revision is now accepted and ready to land.Mar 27 2023, 7:48 AM
This revision was landed with ongoing or failed builds.Mar 27 2023, 8:35 AM
This revision was automatically updated to reflect the committed changes.