This is an archive of the discontinued LLVM Phabricator instance.

[Docs][llvm-mc] Add documentation on --filetype flag
ClosedPublic

Authored by aidengrossman on Mar 25 2023, 10:23 AM.

Details

Summary

Currently the filetype flag is not documented, and knowing the behavior
of this flag is fairly important for doing anything other than
disassembling to text assembly.

Diff Detail

Event Timeline

aidengrossman created this revision.Mar 25 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 10:23 AM
aidengrossman requested review of this revision.Mar 25 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 10:23 AM

I've also noticed that when doing assembly without setting a --filetype, it still defaults to asm, which doesn't make a lot of sense. There should probably be some input validation to ensure that the various modes (eg --assemble and --disassemble) are run with the correct filetypes and automatically provide sensible defaults, since outputting text assembly by default when trying to assemble text assembly doesn't make a lot of sense. I'm planning on opening another patch to fix this behavior.

This revision is now accepted and ready to land.Mar 25 2023, 10:29 AM
This revision was landed with ongoing or failed builds.Mar 25 2023, 10:45 AM
This revision was automatically updated to reflect the committed changes.