This is an archive of the discontinued LLVM Phabricator instance.

[llvm-rc] Remove transitional preprocessing fallback logic
ClosedPublic

Authored by mstorsjo on Mar 24 2023, 3:29 AM.

Details

Summary

When preprocessing was integrated to llvm-rc in 2021, this was a
new requirement (previously one could execute llvm-rc without a
suitable preprocessing tool to be available).

As a transitional helper, llvm-rc fell back on skipping preprocessing
if no suitable tool was found (with a warning printed), but users
could pass an llvm-rc specific option to silence the warning, if they
explicitly want to run the tool without preprocessing.

Now 2 years later, remove the transitional helper - error out if
preprocessing failed. The option for disabling preprocessing remains.

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 24 2023, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 3:29 AM
mstorsjo requested review of this revision.Mar 24 2023, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 3:29 AM
aganea accepted this revision.Mar 24 2023, 7:14 AM

LG.

Just a thought: as future work, we should probably have an integration with LLVM_TOOL_LLVM_DRIVER_BUILD?

This revision is now accepted and ready to land.Mar 24 2023, 7:14 AM

LG.

Just a thought: as future work, we should probably have an integration with LLVM_TOOL_LLVM_DRIVER_BUILD?

Yes, that would probably be good. I haven't really paid much attention to that build mode myself yet though.

This revision was landed with ongoing or failed builds.Mar 28 2023, 1:04 AM
This revision was automatically updated to reflect the committed changes.