This is an archive of the discontinued LLVM Phabricator instance.

Differential D146573

[flang] Catch attempt to apply ASYNCHRONOUS attribute to a non-variable
ClosedPublic

Authored by klausler on Mar 21 2023, 3:03 PM.

Details

Reviewers
PeteSteinfeld
Commits
rGfe8abccbcd47: [flang] Catch attempt to apply ASYNCHRONOUS attribute to a non-variable
Summary

Complain about the ASYNCHRONOUS attribute on symbols that aren't
variables.

Diff Detail

Event Timeline

klausler created this revision.Mar 21 2023, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 3:03 PM
Herald added subscribers: sunshaoce, jdoerfert. · View Herald Transcript
klausler requested review of this revision.Mar 21 2023, 3:03 PM
Harbormaster completed remote builds in B220850: Diff 507139.Mar 21 2023, 4:25 PM
PeteSteinfeld accepted this revision.Mar 21 2023, 5:01 PM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.Mar 21 2023, 5:01 PM
Closed by commit rGfe8abccbcd47: [flang] Catch attempt to apply ASYNCHRONOUS attribute to a non-variable (authored by klausler). · Explain WhyMar 27 2023, 3:14 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rGfe8abccbcd47: [flang] Catch attempt to apply ASYNCHRONOUS attribute to a non-variable.

Revision Contents

PathSize
flang/
lib/
Semantics/
5 lines
test/
Semantics/
4 lines

Diff 507139

flang/lib/Semantics/check-declarations.cpp

Context not available.
" of a module"_err_en_US, " of a module"_err_en_US,
symbol.name()); symbol.name());
} }
if (symbol.attrs().test(Attr::ASYNCHRONOUS) &&
!evaluate::IsVariable(symbol)) {
messages_.Say(
"An entity may not have the ASYNCHRONOUS attribute unless it is a variable"_err_en_US);
}
} }
void CheckHelper::CheckCommonBlock(const Symbol &symbol) { void CheckHelper::CheckCommonBlock(const Symbol &symbol) {
Context not available.

flang/test/Semantics/resolve20.f90

Context not available.
!ERROR: EXTERNAL attribute not allowed on 'bar' !ERROR: EXTERNAL attribute not allowed on 'bar'
external :: bar external :: bar
!ERROR: An entity may not have the ASYNCHRONOUS attribute unless it is a variable
asynchronous :: async
external :: async
!ERROR: PARAMETER attribute not allowed on 'm' !ERROR: PARAMETER attribute not allowed on 'm'
parameter(m=2) parameter(m=2)
!ERROR: PARAMETER attribute not allowed on 'foo' !ERROR: PARAMETER attribute not allowed on 'foo'
Context not available.