Page MenuHomePhabricator
Differential D146316

[compiler-rt] Add missing #else clause to fix the build on NetBSD.
ClosedPublic
Actions

Authored by fcambus on Fri, Mar 17, 11:07 AM.

Details

Reviewers
ro
MaskRay
Commits
rG8510cf9fc1a4: [compiler-rt] Add missing #else clause to fix the build on NetBSD.
Summary

An #elif SANITIZER_SOLARIS clause was removed in D120048, but it also removed the #else clause for the error fallback, causing the build to fail on NetBSD.

Diff Detail

Event Timeline

fcambus created this revision.Fri, Mar 17, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 11:07 AM
Herald added subscribers: Enna1, fedor.sergeev, krytarowski, dberris. · View Herald Transcript
fcambus requested review of this revision.Fri, Mar 17, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 11:07 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B220113: Diff 506143.Fri, Mar 17, 11:36 AM
MaskRay accepted this revision.Sat, Mar 18, 12:08 AM

Thanks!

This revision is now accepted and ready to land.Sat, Mar 18, 12:08 AM
This revision was landed with ongoing or failed builds.Sun, Mar 19, 1:47 AM
Closed by commit rG8510cf9fc1a4: [compiler-rt] Add missing #else clause to fix the build on NetBSD. (authored by fcambus). · Explain Why
This revision was automatically updated to reflect the committed changes.
fcambus added a commit: rG8510cf9fc1a4: [compiler-rt] Add missing #else clause to fix the build on NetBSD..

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
sanitizer_common/
1 line

Diff 506361

View Options

compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp

Loading...