This is an archive of the discontinued LLVM Phabricator instance.

Differential D146300

[flang] Pass box address for bind(c) assumed type dummy argument
ClosedPublic

Authored by clementval on Mar 17 2023, 8:10 AM.

Details

Reviewers
PeteSteinfeld
Commits
rG49d718db86aa: [flang] Pass box address for bind(c) assumed type dummy argument
Summary

When interfacing with C code, assumed type should be passed as
basic pointer.

Diff Detail

Event Timeline

clementval created this revision.Mar 17 2023, 8:10 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 17 2023, 8:10 AM
Herald added subscribers: sunshaoce, mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Mar 17 2023, 8:10 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptMar 17 2023, 8:10 AM
Harbormaster completed remote builds in B220067: Diff 506088.Mar 17 2023, 8:32 AM
PeteSteinfeld accepted this revision.Mar 17 2023, 9:07 AM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.Mar 17 2023, 9:07 AM
This revision was landed with ongoing or failed builds.Mar 17 2023, 9:59 AM
Closed by commit rG49d718db86aa: [flang] Pass box address for bind(c) assumed type dummy argument (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG49d718db86aa: [flang] Pass box address for bind(c) assumed type dummy argument.

Revision Contents

PathSize
flang/
lib/
Lower/
9 lines
test/
Lower/
4 lines

Diff 506123

flang/lib/Lower/CallInterface.cpp

Show First 20 Lines • Show All 959 Lines • ▼ Show 20 Lines if (!bounds.empty())
type = fir::SequenceType::get(bounds, type); type = fir::SequenceType::get(bounds, type);
if (obj.attrs.test(Attrs::Allocatable)) if (obj.attrs.test(Attrs::Allocatable))
type = fir::HeapType::get(type); type = fir::HeapType::get(type);
if (obj.attrs.test(Attrs::Pointer)) if (obj.attrs.test(Attrs::Pointer))
type = fir::PointerType::get(type); type = fir::PointerType::get(type);
mlir::Type boxType = fir::wrapInClassOrBoxType( mlir::Type boxType = fir::wrapInClassOrBoxType(
type, obj.type.type().IsPolymorphic(), obj.type.type().IsAssumedType()); type, obj.type.type().IsPolymorphic(), obj.type.type().IsAssumedType());
if (obj.attrs.test(Attrs::Allocatable) || obj.attrs.test(Attrs::Pointer)) { if (obj.type.type().IsAssumedType() && isBindC) {
mlir::Type voidPtrType = fir::ReferenceType::get(
mlir::NoneType::get(&interface.converter.getMLIRContext()));
addFirOperand(voidPtrType, nextPassedArgPosition(), Property::BaseAddress,
attrs);
addPassedArg(PassEntityBy::BaseAddress, entity, characteristics);
} else if (obj.attrs.test(Attrs::Allocatable) ||
obj.attrs.test(Attrs::Pointer)) {
// Pass as fir.ref<fir.box> or fir.ref<fir.class> // Pass as fir.ref<fir.box> or fir.ref<fir.class>
mlir::Type boxRefType = fir::ReferenceType::get(boxType); mlir::Type boxRefType = fir::ReferenceType::get(boxType);
addFirOperand(boxRefType, nextPassedArgPosition(), Property::MutableBox, addFirOperand(boxRefType, nextPassedArgPosition(), Property::MutableBox,
attrs); attrs);
addPassedArg(PassEntityBy::MutableBox, entity, characteristics); addPassedArg(PassEntityBy::MutableBox, entity, characteristics);
} else if (dummyRequiresBox(obj)) { } else if (dummyRequiresBox(obj)) {
// Pass as fir.box or fir.class // Pass as fir.box or fir.class
if (isValueAttr) if (isValueAttr)
▲ Show 20 Lines • Show All 442 Lines • Show Last 20 Lines

flang/test/Lower/polymorphic-types.f90

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines
! Test assumed type argument types ! Test assumed type argument types
! ------------------------------------------------------------------------------ ! ------------------------------------------------------------------------------
subroutine assumed_type_dummy(a) bind(c) subroutine assumed_type_dummy(a) bind(c)
type(*) :: a type(*) :: a
end subroutine assumed_type_dummy end subroutine assumed_type_dummy
! CHECK-LABEL: func.func @assumed_type_dummy( ! CHECK-LABEL: func.func @assumed_type_dummy(
! CHECK-SAME: %{{.*}}: !fir.box<none> ! CHECK-SAME: %{{.*}}: !fir.ref<none>
subroutine assumed_type_dummy_array(a) bind(c) subroutine assumed_type_dummy_array(a) bind(c)
type(*) :: a(:) type(*) :: a(:)
end subroutine assumed_type_dummy_array end subroutine assumed_type_dummy_array
! CHECK-LABEL: func.func @assumed_type_dummy_array( ! CHECK-LABEL: func.func @assumed_type_dummy_array(
! CHECK-SAME: %{{.*}}: !fir.box<!fir.array<?xnone>> ! CHECK-SAME: %{{.*}}: !fir.ref<none>
end module end module