Make code size metric names independent of platform

[paquette]

Summary

On Darwin/mach-o, llvm-size (and size) will output something like

__text

While on other platforms (e.g. GNU) you'll get

.text

codesize.py was basically pushing that platform-specific info along in its size
related output.

So, depending on the platform, we'd get

size.__text
size..text

Tools downstream from the test suite then would have to handle whatever output
the target-specific tools would produce.

Instead of doing that, let's just output something like

size_text

So all downstream consumers can just handle one single format.

This is in tandem with D146257 in LNT.

[fhahn]

LGTM, thanks!

@cmatthews @azhar do you know if there are any tests for this part of the code?

[paquette]

Over in D146257 we decided that we don't want to change the test suite, and would prefer the change to be local to LNT. We don't need this change.

[azharudd]

@jpaquette, what do you think?

litsupport/modules/codesize.py

42

I was just thinking maybe, as a good measure, we can assert here that only one of size.__text or size..text is present in metrics.

assert not ('size.__text' in metrics and 'size..text' in metrics), "Both 'size.__text' and 'size..text' present in metrics. Only one of them should exist."

[paquette]

litsupport/modules/codesize.py

42

Sure, that sounds like a good idea. Lemme spin up another patch.

litsupport/modules/codesize.py

if os.path.exists(filename):
                     continue
                 values = line.split()
                 if len(values) < 2:
                     logging.info("Ignoring malformed output line: %s", line)
                     continue
                 if values[0] == 'Total':
                     continue
                 try:
-                    name = values[0]
+                    # Strip leading underscores and periods, which are
+                    # platform-dependent. E.g. __text -> text or .text -> text
+                    name = values[0].lstrip("__").lstrip(".")
                     val = int(values[1])
-                    metrics['size.%s' % name] = val
+                    metrics['size_%s' % name] = val
                 except ValueError:
                     logging.info("Ignoring malformed output line: %s", line)
 
     return metrics
 
 
 def mutatePlan(context, plan):
     plan.metric_collectors.append(_getCodeSize)