This is an archive of the discontinued LLVM Phabricator instance.

Differential D146246

[InferTypeOpInterface.h] Remove extra '\' at the end of comment line
AcceptedPublic

Authored by xerpi on Mar 16 2023, 10:23 AM.

Details

Reviewers
rriddle
Summary

Triggers a warning when compiling with -Wcomment.

Fixes:

In file included from /home/xerpi/Desktop/Research/circt/llvm/mlir/include/mlir/Dialect/Arith/IR/Arith.h:17,
                 from /home/xerpi/Desktop/Research/Halide/src/CodeGen_CIRCT.cpp:7:
/home/xerpi/Desktop/Research/circt/llvm/mlir/include/mlir/Interfaces/InferTypeOpInterface.h:269:1: warning: multi-line comment [-Wcomment]
  269 | ///   these always populates all element types and shapes or fails, but this\

Diff Detail

Event Timeline

xerpi created this revision.Mar 16 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 10:23 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 21 others. · View Herald Transcript
xerpi requested review of this revision.Mar 16 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 10:23 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
xerpi edited the summary of this revision. (Show Details)Mar 16 2023, 10:24 AM
rriddle accepted this revision.Mar 16 2023, 10:24 AM
This revision is now accepted and ready to land.Mar 16 2023, 10:24 AM
Harbormaster completed remote builds in B219914: Diff 505866.Mar 16 2023, 11:45 AM

Revision Contents

PathSize
mlir/
include/
mlir/
Interfaces/
2 lines

Diff 505866

mlir/include/mlir/Interfaces/InferTypeOpInterface.h

Show First 20 Lines • Show All 266 Lines • ▼ Show 20 Lines
namespace mlir { namespace mlir {
namespace OpTrait { namespace OpTrait {
/// Tensor type inference trait that constructs a tensor from the inferred /// Tensor type inference trait that constructs a tensor from the inferred
/// shape and elemental types. /// shape and elemental types.
/// Requires: Op implements InferShapedTypeOpInterface and InferTypeOpInterface. /// Requires: Op implements InferShapedTypeOpInterface and InferTypeOpInterface.
/// Less strict is possible (e.g., implements inferReturnTypeComponents and /// Less strict is possible (e.g., implements inferReturnTypeComponents and
/// these always populates all element types and shapes or fails, but this\ /// these always populates all element types and shapes or fails, but this
/// trait is currently only used where the interfaces are, so keep it /// trait is currently only used where the interfaces are, so keep it
/// restricted for now). /// restricted for now).
template <typename ConcreteType> template <typename ConcreteType>
class InferTensorType : public TraitBase<ConcreteType, InferTensorType> { class InferTensorType : public TraitBase<ConcreteType, InferTensorType> {
public: public:
static LogicalResult static LogicalResult
inferReturnTypes(MLIRContext *context, std::optional<Location> location, inferReturnTypes(MLIRContext *context, std::optional<Location> location,
ValueRange operands, DictionaryAttr attributes, ValueRange operands, DictionaryAttr attributes,
Show All 18 Lines