This is an archive of the discontinued LLVM Phabricator instance.

[test][MemDep] Correct the 'NOT' checks in the invalidation.ll test case. NFC
ClosedPublic

Authored by bjope on Mar 16 2023, 2:47 AM.

Details

Summary

The MemoryDependenceAnalysis/invalidation.ll test case was using

; CHECK-NOT-AA-INVALIDATE:

but I think the intention was to use

; CHECK-AA-INVALIDATE-NOT:

Simply changing the checks like that would make the test fail.

The old statement that AA being stateless would result in nothing
to invalidate when doing invalidate<aa> is not true afaict.
It would be different if for example doing invalidate<basic-aa>, then
the AAManager isn't invalidated (and then neither memdep would be
invalidated). But when the AAManager itself is invalidated then we
should expect to find both "Invalidating analysis: AAManager" and
"Invalidating analysis: MemoryDependenceAnalysis" in the output.

Diff Detail

Event Timeline

bjope created this revision.Mar 16 2023, 2:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 2:47 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
bjope requested review of this revision.Mar 16 2023, 2:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 2:47 AM
This revision is now accepted and ready to land.Mar 16 2023, 2:49 AM