Page MenuHomePhabricator

[clang][NFC] Fix location of 2>&1 in a few -print tests
ClosedPublic

Authored by ldionne on Wed, Mar 15, 10:49 AM.

Details

Summary

While it's apparently valid to place Bash redirections anywhere in a
command-line, it is by far most frequently placed last. This changes
a few tests that did not conform to this convention and which I
originally thought were wrong.

Diff Detail

Event Timeline

ldionne created this revision.Wed, Mar 15, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 15, 10:49 AM
ldionne requested review of this revision.Wed, Mar 15, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 15, 10:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Gentle ping, this was likely a copy-paste error.

Adding Aaron in case he has time to take a look.

phosek accepted this revision.Wed, Mar 22, 10:05 AM

LGTM

This revision is now accepted and ready to land.Wed, Mar 22, 10:05 AM
MaskRay accepted this revision.Wed, Mar 22, 2:21 PM

Thank you!

(A somewhat common practice is to prefer [test] over [NFC] for pure-test changes (no code change) :)
I see that " in a few -print tests" in the subject may render [test] unneeded.. perhaps what tag is used isn't really important.)

This revision was automatically updated to reflect the committed changes.