[clang][NFC] Fix location of 2>&1 in a few -print tests
ClosedPublic
Actions

Authored by ldionne on Wed, Mar 15, 10:49 AM.

Details

Reviewers

phosek
MaskRay
aaron.ballman

Commits

rG731264b0c2af: [clang][NFC] Fix location of 2>&1 in a few -print tests

Summary

While it's apparently valid to place Bash redirections anywhere in a
command-line, it is by far most frequently placed last. This changes
a few tests that did not conform to this convention and which I
originally thought were wrong.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ldionne created this revision.Wed, Mar 15, 10:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 15, 10:49 AM

ldionne requested review of this revision.Wed, Mar 15, 10:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 15, 10:49 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

ldionne added reviewers: phosek, MaskRay.Wed, Mar 15, 10:51 AM

Harbormaster completed remote builds in B219689: Diff 505566.Wed, Mar 15, 11:54 AM

Gentle ping, this was likely a copy-paste error.

Adding Aaron in case he has time to take a look.

LGTM

This revision is now accepted and ready to land.Wed, Mar 22, 10:05 AM

LGTM!

MaskRay accepted this revision.Wed, Mar 22, 2:21 PM

Thank you!

(A somewhat common practice is to prefer [test] over [NFC] for pure-test changes (no code change) :)
I see that " in a few -print tests" in the subject may render [test] unneeded.. perhaps what tag is used isn't really important.)