This is an archive of the discontinued LLVM Phabricator instance.

[mlir] tosa.concat - Add InferTensorType interface
ClosedPublic

Authored by mamrami on Mar 15 2023, 6:01 AM.

Details

Summary

When this interface is used, a call to inferReturnTypeComponents()
is generated on creation and verification of the op.
A few changes were required in inferReturnTypeComponents():

  • Emit error when it fails. The verifier calls this method now, and it is preferable to indicate what caused the failure.
  • Fix the inferred return shapes so they have a type too.

Diff Detail

Event Timeline

mamrami created this revision.Mar 15 2023, 6:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 6:01 AM
mamrami requested review of this revision.Mar 15 2023, 6:01 AM
mamrami updated this revision to Diff 505751.Mar 16 2023, 3:18 AM

Rebase after the bug in flang fixed

rsuderman accepted this revision.Mar 20 2023, 1:22 PM
This revision is now accepted and ready to land.Mar 20 2023, 1:22 PM
This revision was automatically updated to reflect the committed changes.